Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
From: Jorg Walter
To: email@example.com Subject: Bug in zip archiver Date: Sat, 23 Jul 2005 22:19:09 +0200 Hi! PhysFS has a bug in the ZIP archive module, function zip_find_start_of_dir. Upon encountering a substring match, rc is set to a wrong value. The fix is simple: swap both assignments like this: [patch below --Ed.] Some additional info for testing: Symptoms when you encounter this bug: A dir is reported as empty although it has files in it; prerequisites or encountering it: two dirs, one a substring of another, like "data/txt" and "data/txt2", laid out in a way so that variable "middle" points to a file in txt2 at some point during zip_find_start_of_dir By the way, if you're interested in where PhysFS is used: I found this bug while writing a patch for DOSBox (http://dosbox.sourceforge.net) to support ZIP files. And I'd love to see that enhanced PHYSFS_mount syntax in an official release soon *hint* ;);)
- Loading branch information