Skip to content

Conversation

@akazakou
Copy link
Contributor

@akazakou akazakou commented Feb 21, 2019

Changeset to #64 issue:

  • Exporting defined types
  • Remove declare construction that is not required
  • Fix compile to allow an array of validation objects as an input parameter
  • Update check function, it returns only true or error description

@akazakou
Copy link
Contributor Author

Someone can review it?

@akazakou akazakou changed the title icebob/fastest-validator#64 issue fixes Fix wrong TypeScript types Feb 21, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1bbfc55 on akazakou:fix/fix-wrong-typings into 11a600a on icebob:master.

@icebob
Copy link
Owner

icebob commented Feb 21, 2019

@anri-asaturov ?

Copy link
Contributor

@anri-asaturov anri-asaturov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
TBD more typings and test for typings, maybe I'll be able to do that soon.

@icebob icebob merged commit 38bd64a into icebob:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants