New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust for icecream change that has broken scheduler discovery #40

Merged
merged 1 commit into from Jul 1, 2018

Conversation

Projects
None yet
1 participant
@llunak
Copy link
Contributor

llunak commented Jul 1, 2018

47ba035 in icecream has changed
the discovery to always timeout and only then return a scheduler.
So first checking for timeout and only then trying to get a scheduler
now never provides the scheduler. Change the code the same way
iceccd has been changed in that commit.

@llunak llunak force-pushed the llunak:master branch from da67e12 to 5d7e1c8 Jul 1, 2018

adjust for icecream change that has broken scheduler discovery
47ba035 in icecream has changed
the discovery to always timeout and only then return a scheduler.
So first checking for timeout and only then trying to get a scheduler
now never provides the scheduler. Change the code the same way
iceccd has been changed in that commit.

@llunak llunak force-pushed the llunak:master branch from 5d7e1c8 to d71e595 Jul 1, 2018

@llunak llunak merged commit 9740aed into icecc:master Jul 1, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment