merge git send-email and git imap-send achievement #61

Open
wants to merge 5 commits into
from

Conversation

Projects
None yet
1 participant
@rgenoud

rgenoud commented Jun 29, 2012

git send-email and git imap-send do basically the same thing.
I think they should unlock the same achievement. (Postman)

rgenoud added some commits Jun 29, 2012

merge git send-email and git imap-send achievement
git send-email and git imap-send do basically the same thing.
I think they should unlock the same achievement. (Postman)
[BUG] count_command: correct the regex matching commands
this caused a problem with git am for example, because every action with
am in it was a match.
Thus, commit --amend was a match, git blame was a match etc...
[BUG] count_command: do not match --help commands
when a git xxx --help command is issued, the only achievement unlocked
is Student, then the function returns.
So, "git add --help" for exemple does not fire the
count_unlock_achievement function.
BUT the count_command counts the git add --help commands, that's why
some achievements are missed :
if you start from scratch and then do :
git add toto
git add --help
git add titi
=> you should have the add achievement level 1 and you don't...
@rgenoud

This comment has been minimized.

Show comment
Hide comment
@rgenoud

rgenoud Jul 6, 2012

I found and corrected 2 bugs
As I'm not familiar with awk, I used a grep -v to unmatch --help lines...

rgenoud commented Jul 6, 2012

I found and corrected 2 bugs
As I'm not familiar with awk, I used a grep -v to unmatch --help lines...

rgenoud added some commits Jul 10, 2012

don't count git x --help commands in web page
otherwise, you could have 34 git commits on the index.html page for
instance, and still be Author level 4 because of the 3 or more git
commit --help commands
Speed up the commit without a parent test
There's no need to do the full git log to check if there's only one
entry.
git log -2 is enough.

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment