preliminary AWS access #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so contributors are aware that this repo is participating in a research project and metrics will be gathered over the next 12 months :)
Codecov Report
@@ Coverage Diff @@
## development #213 +/- ##
===============================================
- Coverage 55.50% 55.02% -0.49%
===============================================
Files 20 20
Lines 1526 1543 +17
Branches 317 321 +4
===============================================
+ Hits 847 849 +2
- Misses 622 636 +14
- Partials 57 58 +1
Continue to review full report at Codecov.
|
* create uml_action yml file * debug * fix path typo * try a different action first option tried was limited to master branch pushes * add dot to args * add class dot file from pyreverse * update path to find dot files * try different path to dot file * run action to test graphviz install * try different input file format * add start and end flags to dot file * Update uml_action.yml * update path * update path in second location * add commit changes * GitHub PlantUML generation auto-update * remove graphvizdot flag * GitHub PlantUML generation auto-update * add graphviz testdot flag back * switch to svg * remove changes * GitHub PlantUML generation auto-update * try as a uml instead of dot * try using pyreverse directly * add package install * try non-pip install of graphviz * add sudo * add requirements install * ignore tests and install icepyx * fix path to find file * fix path to find file * GitHub PlantUML generation auto-update * try using current branch for commit * remove plantuml and png files * generate umls and remove extra files from testing * update docs with new uml diagrams. Add visualization class to components list * update action trigger to after approved pull request reviews Co-authored-by: Romina Piunno <romina.piunno@gmail.com>
* change 'dataset' to 'product' in core and test code * update 'source' input parameter to 'path' in variables module (part of a not-yet-implemented feature).
* update and run tests that require an active NSIDC Earthdata session * add flat data resource note * NOTE: using the fixture to successfully start a session can be considered the test * transition options to json for cleaner test file
…openaltimetry visualization (#220) Co-authored-by: Jessica <JessicaS11@users.noreply.github.com>
…R (product_id --> title) (#218)
JessicaS11
force-pushed
the
development
branch
from
130528b
to
247725c
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
JessicaS11
commented
Oct 12, 2021
This was referenced Oct 15, 2021
betolink
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Great work Jessica, one thing to maybe take into account is that EGI subsetting is not available for cloud granules. I think the plan is that NASA Harmony will become the de facto subsetter for cloud collections. Right now ATL data is not supported by Harmony but when it does It should be fairly simple to integrate it with icepyx.
JessicaS11
added a commit
that referenced
this pull request
Dec 8, 2021
* add github action to add binder badge to PRs (#229) * use the binder badge action directly (instead of a manual implementation of it) (#233) See the discussion in #230 for more details on this switch. * preliminary AWS access (#213) * update links for travis badge (#234) * Fix failing test_visualization_date_range check for ATL07 (#241) * By default, no email status updates to users when ordering granules (#240) * remove extra cell causing errors in example notebook * Set default page size for orders to 2000 per NSIDC recommendation (#239) * Add ICESat-2 data read-in functionality (#222) * update examples from 2020 Hackweek tutorials * update add and commit GitHub Action version (and UML diagrams) (#244) * merge traffic (GitHub and PyPI) and bib updates (#245) * Release 0.5.0 (#246) * release v0.5.0 CI fixes (#251) * fix Travis CI label in readme * update earthdata login fixture for testing * add required input to pytest fixture (#252) Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: trey-stafford <trey.stafford@colorado.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently a host of caveats to ICESat-2 cloud data access (including that it is NOT YET PUBLIC and STILL IN DEVELOPMENT), but this is a start towards some of the items that will be needed to enable it:
Acknowledging these caveats, I think we can move forward with reviewing this PR so that other beta testers can use the functionality, and we can continue improving cloud data access as we go.