New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag 1.99.1 not correct #111

Closed
nono303 opened this Issue Jan 22, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@nono303
Copy link

nono303 commented Jan 22, 2019

Hi Stefan,

  1. Tag 1.99.1 seems not include all 1.99.1 files in master (see ex. https://github.com/icing/mod_md/blob/v1.99.1/src/md_version.h still in 1.99.0)

  2. Also have a misspelling in md_acmev2_drive.c l. 171

  3. Finaly I’ve tested ACMEv2 with success in staging mode but In prod mode I can’t’ retrieve more than 10 MDomain because of the following error md:warn md_acme.c(183) pid:2556 [acme problem urn:ietf:params:acme:error:rateLimited: Error creating new account :: too many registrations for this IP: see https://letsencrypt.org/docs/rate-limits/]
    So my question: is that the normal behavior to create a new account for each MDomain?
    As I can see onto my accounts dir in the MDStoreDir path for ACMEv1, I only have 2 accounts for all my MDomains (23…) and never had a rate limit problem.

Thanks for your feedback!

Arnaud

@icing

This comment has been minimized.

Copy link
Owner

icing commented Jan 22, 2019

Hey @nono303 ! Thanks for testing this bleeding edge thing! As to the bullets:

  1. My mistake, will watch out in the next release.
  2. fixed (local).
  3. Great catch! STAGING does not find a usable account, so it creates a new one. And as a new created account is kept in STAGING at first (no other place is writeable), each domain creates a new account in its STAGING. I think I need to change the strategy here...
@icing

This comment has been minimized.

Copy link
Owner

icing commented Jan 22, 2019

In release v1.99.2 the multi-account problem should be fixed. At least the new tests say so...

@nono303

This comment has been minimized.

Copy link
Author

nono303 commented Jan 23, 2019

Hi @icing,
Thanks four your fast action ^^
1.99.2 correct the account issue : I've tested it in stagging & prod and everything went well with ACMEv2 ;)
I've updated windows release on https://github.com/nono303/mod_md/tree/v1.99.2

@nono303 nono303 closed this Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment