New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement WorkQueue metric stats and periodic logging #5280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnsmichi
added
area/api
REST API
area/distributed
Distributed monitoring (master, satellites, clients)
enhancement
New feature or request
area/log
Logging related
labels
May 22, 2017
dnsmichi
force-pushed
the
feature/workqueue-stats
branch
2 times, most recently
from
May 23, 2017 13:48
c0bcfcf
to
fc726a0
Compare
dnsmichi
changed the title
WIP: Implement WorkQueue stats and logging
Implement WorkQueue stats and periodic logging
May 23, 2017
dnsmichi
changed the title
Implement WorkQueue stats and periodic logging
Implement WorkQueue metric stats and periodic logging
May 23, 2017
dnsmichi
force-pushed
the
feature/workqueue-stats
branch
from
May 23, 2017 14:00
fc726a0
to
456cfdc
Compare
dnsmichi
pushed a commit
that referenced
this pull request
May 24, 2017
dnsmichi
pushed a commit
that referenced
this pull request
May 24, 2017
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/api
REST API
area/distributed
Distributed monitoring (master, satellites, clients)
area/log
Logging related
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only log an entry if
There's also the current rate calculation and "queue empty" estimation as you know from the IDO feature already.
This PR also solves the problem of spamming the log with empty queues every 10 seconds.
Any feature which uses a work queue in the future will get those metrics and logs "for free".
Bonus: Rate calculation is available to any work queue owner, so it can be used for API and built-in performance data metrics too in #5266 and #5133.