New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Injector doesn't work if there is a URL parameter #17

Closed
majksner opened this Issue Jul 31, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@majksner

majksner commented Jul 31, 2014

<img data-src="/build/img/logo.svg?v=0.1.81" data-fallback="/build/img/logo.png?v=0.1.81" class="svg" alt="Logo">

protodave added a commit that referenced this issue Oct 15, 2014

Fix for issue #17 - "SVG Injector doesn't work if there is a URL para…
…meter". Updated the regex that was matching for an svg file extension to allow for query strings.
@protodave

This comment has been minimized.

Show comment
Hide comment
@protodave

protodave Oct 15, 2014

Contributor

Fixed this by updating the regex that was matching the SVG file extension to allow for query strings. Adding a version # query string to assets is a common cache-busting technique used by CDNs (including Shopify).

Contributor

protodave commented Oct 15, 2014

Fixed this by updating the regex that was matching the SVG file extension to allow for query strings. Adding a version # query string to assets is a common cache-busting technique used by CDNs (including Shopify).

@protodave protodave closed this Oct 15, 2014

@renestalder

This comment has been minimized.

Show comment
Hide comment
@renestalder

renestalder Oct 23, 2014

@protodave is this already included in the current iconic.js? It seems not to work.

renestalder commented Oct 23, 2014

@protodave is this already included in the current iconic.js? It seems not to work.

@protodave

This comment has been minimized.

Show comment
Hide comment
@protodave

protodave Oct 24, 2014

Contributor

Not yet, but It'll be in the next Iconic release, v1.7.0, which is almost ready. If you want the updated iconic.js sooner just shoot me an email to yourfriends -at- useiconic.com and I'll sent it to you!

Contributor

protodave commented Oct 24, 2014

Not yet, but It'll be in the next Iconic release, v1.7.0, which is almost ready. If you want the updated iconic.js sooner just shoot me an email to yourfriends -at- useiconic.com and I'll sent it to you!

@renestalder

This comment has been minimized.

Show comment
Hide comment
@renestalder

renestalder Oct 27, 2014

@protodave Thanks Dave. I temporary added the fix myself to the minified iconic.js (since it's really to update the regex).

I'm okay with waiting for the official release.

renestalder commented Oct 27, 2014

@protodave Thanks Dave. I temporary added the fix myself to the minified iconic.js (since it's really to update the regex).

I'm okay with waiting for the official release.

@protodave

This comment has been minimized.

Show comment
Hide comment
@protodave

protodave Oct 27, 2014

Contributor

Ok, great, thanks. The new Iconic release should be out in the next couple of days.

Contributor

protodave commented Oct 27, 2014

Ok, great, thanks. The new Iconic release should be out in the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment