SVG Injector doesn't work if there is a URL parameter #17

Closed
majksner opened this Issue Jul 31, 2014 · 5 comments

Projects

None yet

3 participants

@majksner
<img data-src="/build/img/logo.svg?v=0.1.81" data-fallback="/build/img/logo.png?v=0.1.81" class="svg" alt="Logo">
@protodave protodave added a commit that referenced this issue Oct 15, 2014
@protodave protodave Fix for issue #17 - "SVG Injector doesn't work if there is a URL para…
…meter". Updated the regex that was matching for an svg file extension to allow for query strings.
55ac808
@protodave
Contributor

Fixed this by updating the regex that was matching the SVG file extension to allow for query strings. Adding a version # query string to assets is a common cache-busting technique used by CDNs (including Shopify).

@protodave protodave closed this Oct 15, 2014
@renestalder

@protodave is this already included in the current iconic.js? It seems not to work.

@protodave
Contributor

Not yet, but It'll be in the next Iconic release, v1.7.0, which is almost ready. If you want the updated iconic.js sooner just shoot me an email to yourfriends -at- useiconic.com and I'll sent it to you!

@renestalder

@protodave Thanks Dave. I temporary added the fix myself to the minified iconic.js (since it's really to update the regex).

I'm okay with waiting for the official release.

@protodave
Contributor

Ok, great, thanks. The new Iconic release should be out in the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment