Fix PCRE with UTF-8 data on Windows #145

Open
cdornan opened this Issue Jun 4, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@cdornan
Contributor

cdornan commented Jun 4, 2017

  • regex-pcre has never worked with UTF8 data due to #141 (and it was never guaranteed).

  • Currently it is not working on Windows (at least on AppVeyor) and the Windows UTF-8/PCRE tests have been suspended.

  • The current method of fixing up the offsets in regex is hacky and inefficient.

@cdornan cdornan changed the title from Fix PCRE with UTF-8 data to Fix PCRE with UTF-8 data on Windows Jun 8, 2017

@cdornan

This comment has been minimized.

Show comment
Hide comment
@cdornan

cdornan Jun 8, 2017

Contributor

BTW, this issue was reported at regex-pcre-builtin.

Contributor

cdornan commented Jun 8, 2017

BTW, this issue was reported at regex-pcre-builtin.

@cdornan cdornan modified the milestone: v1.0.2.0 Jun 10, 2017

@cdornan cdornan added the in progress label Jun 10, 2017

@cdornan cdornan self-assigned this Jun 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment