Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bounds need updates for GHC 8.8.1 stack nightly snapshots #173

Open
vdukhovni opened this issue Nov 11, 2019 · 5 comments
Open

Version bounds need updates for GHC 8.8.1 stack nightly snapshots #173

vdukhovni opened this issue Nov 11, 2019 · 5 comments

Comments

@vdukhovni
Copy link

@vdukhovni vdukhovni commented Nov 11, 2019

  • hashable-1.3.0.0
  • regex-base-0.94.0.0
  • regex-pcre-builtin-0.95.1.1.8.43
@vdukhovni

This comment has been minimized.

Copy link
Author

@vdukhovni vdukhovni commented Nov 11, 2019

Also for the regex-with-pcre package:

  • regex-base-0.94.0.0
  • regex-pcre-builtin-0.95.1.1.8.43
  • regex-tdfa-1.3.0
@Drezil

This comment has been minimized.

Copy link

@Drezil Drezil commented Nov 22, 2019

As far as i see in my environment the dependency on regex-tdfa-text must be changed/dropped as this clashes with regex-base-0.94.0.0 (both define instances for Extract Text. This was a breaking change in regex-base-0.94.0.0; see https://github.com/haskell-hvr/regex-base/blob/master/ChangeLog.md)

@vdukhovni

This comment has been minimized.

Copy link
Author

@vdukhovni vdukhovni commented Nov 23, 2019

I don't recall the exact set of dependency issues, but yes there may well be related issues in other packages. I filed tickets for some of the other packages also. Don't know what the final compatible combination will be.
I hope you're able to sort this out for this package.

@Drezil

This comment has been minimized.

Copy link

@Drezil Drezil commented Nov 25, 2019

    Build-depends:
        array                >= 0.4
      , base                 >= 4        && <  5
      , base-compat          >= 0.6 && <0.12
      , bytestring           == 0.10.*
      , containers           >= 0.4
      , hashable             == 1.3.*
      , regex-base           == 0.94.*
      , regex-pcre-builtin   == 0.95.*
      , regex-tdfa           == 1.3.*
      , template-haskell     >= 2.7
      , text                 == 1.2.*
      , time                 >= 1.4.2
      , time-locale-compat   == 0.1.*
      , transformers         >= 0.2.2
      , unordered-containers == 0.2.*
      , utf8-string          >= 1

seems to compile further.

First error appearing gets fixed by

instance RegexLike Regex T.Text
instance RegexLike Regex LT.Text

but these orphan-instances should be in regex-base or something.

Next problem i found was in Text/RE/ZeInternals/NamedCaptures.lhs - here error gets used everywhere - which must not be due to the elimination of fail from Monad by the MonadFail-Proposal. So most of that file needs to be rewritten.. I have to see if i can make time for that ..
(That is file 21/47.. and now i give up hoping for a 'quick fix' .. -.-)

@vdukhovni

This comment has been minimized.

Copy link
Author

@vdukhovni vdukhovni commented Nov 26, 2019

Next problem i found was in Text/RE/ZeInternals/NamedCaptures.lhs - here error gets used everywhere - which must not be due to the elimination of fail from Monad by the MonadFail-Proposal. So most of that file needs to be rewritten.. I have to see if i can make time for that ..

Thanks a bunch for looking into this, much appreciated and good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.