/regex

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type safe replacement templates #60

Closed
cdornan opened this Issue Mar 10, 2017 · 3 comments

Comments

Assignees

@cdornan cdornan

Labels
in progress
Projects
None yet
Milestone
  v0.9.0.0
2 participants
@cdornan @bergmark
@cdornan
Contributor

cdornan commented Mar 10, 2017

Adam Bergmark asked on Haskell Cafe:

Have you considered doing anything fancy to make capture groups safer to use? If i could get a compile error when i'm using the wrong number/wrongly named groups I'd be very excited.

@cdornan cdornan added the help wanted label Mar 10, 2017

@cdornan cdornan added this to the v2.0.0.0 milestone Mar 10, 2017

@cdornan

This comment has been minimized.

Sign in to view
Contributor

cdornan commented Mar 10, 2017

Just to be clear, that was @bergmark of course.

@cdornan cdornan removed the help wanted label Mar 15, 2017

@cdornan cdornan self-assigned this Mar 15, 2017

@cdornan cdornan added the up next label Mar 15, 2017

@cdornan cdornan changed the title from Check captures at compile time to Type safe replacement templates Mar 15, 2017

@cdornan

This comment has been minimized.

Sign in to view
Contributor

cdornan commented Mar 15, 2017

I can see a reasonably safe way of providing type-safe replacement templates with named capture groups, which could be included in v1.0.0.0 so I will provide those and see how much remains to be done and what our options are once we have integrated those.

@cdornan cdornan modified the milestones: v2.0.0.0, v0.8.0.0 Mar 15, 2017

@bergmark

This comment has been minimized.

Sign in to view
Contributor

bergmark commented Mar 18, 2017

Great stuff!

@cdornan cdornan added in progress and removed up next labels Mar 22, 2017

cdornan added a commit that referenced this issue Mar 25, 2017

@cdornan
0.9.0.0: Finish tidying up the API, add type-safe replacement templates 
  * Flip the order of the arguments to replace (fixes #78)
  * Add type-safe replacement templates (fixes #60)
  * Finish tidying up the API (fixes #80)
  * Make `regex` compatible w/ TH-less GHCs (fixes #70)
  * Declare extensions the compiler must support (fixes #83)
  * Fix curl for AppVeyor build (fixes #79)
  * Fix AppVeyor badge (fixes #81)
  * Remove QQ from code coverage stats (fixes #82)
  * Rename Options, Context and Replace methods (fixes #84)
9f24a3f

@cdornan cdornan referenced this issue Mar 25, 2017

Merged

0.9.0.0: Finish tidying up the API, add type-safe replacement templates #85

@cdornan cdornan closed this in #85 Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment