Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use calculated contest time to determine recent events #56

Closed
deboer-tim opened this issue Oct 30, 2019 · 2 comments
Closed

Use calculated contest time to determine recent events #56

deboer-tim opened this issue Oct 30, 2019 · 2 comments
Assignees
@deboer-tim

Comments

@deboer-tim
Copy link
Collaborator

As reported through Nicky and Tobi's via Slack, ContestUtil still uses the 'last event' to determine what the time is in the contest, since it was written well before the Contest API. As a result, scoreboard cells may flash more than the 5 minutes for recent events if there aren't any new events. Will switch to using the calculated contest time instead.
@deboer-tim deboer-tim self-assigned this Oct 30, 2019
@nickygerritsen
Copy link
Collaborator

I'm glad you still remembered that we told you this, because I totally forgot 🤣

@deboer-tim
Copy link
Collaborator Author

Fixed via PR #75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deboer-tim deboer-tim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickygerritsen @deboer-tim