Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VB -> C#: Do not explicitly call Finalize #269

Closed
mrmonday opened this Issue Apr 5, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@mrmonday
Copy link
Contributor

mrmonday commented Apr 5, 2019

Input code

Public Class Class1
    Protected Overrides Sub Finalize()
        MyBase.Finalize()
    End Sub
End Class

Erroneous output

public class Class1
{
    ~Class1()
    {
        base.Finalize();
    }
}

Expected output

public class Class1
{
    ~Class1()
    {
    }
}

Details

Product in use: VS extension

Version in use: 6.6.0

Error from C#:

CS0250	Do not directly call your base class Finalize method. It is called automatically from your destructor.

mrmonday added a commit to mrmonday/CodeConverter that referenced this issue Apr 8, 2019

@mrmonday mrmonday referenced this issue Apr 8, 2019

Merged

Ensure base.Finalize() is removed #275

1 of 2 tasks complete

mrmonday added a commit to mrmonday/CodeConverter that referenced this issue Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.