Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add initial support for VB MyClass expressions [#260] #273
For naming, I'd go for MyClassF1.
When converting a virtual method, look for usages of its symbol within the class (there's a Roslyn API for finding usages) and see if any are a myclass reference (not quite sure how to do the second bit, but it has to be symbolic to deal with partial classes).
Let me know if that doesn't make enough sense and I'll go and poke around the code a bit.
I'm pretty happy with where this is now - there's one case missing, which I've documented, and will throw an exception.
Finding if we need to introduce an extra method is a little messy - I traverse up the AST to find the class we're in, then back down again. I looked into using
There are a few things which could probably be cleaned up, happy do do so if there's anything specific that you see.
Hopefully I've not messed up line endings again here.