Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order constraints when converting from VB to C# #274

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@mrmonday
Copy link
Contributor

mrmonday commented Apr 8, 2019

Closes #271

Problem

When converting from VB to C#, new constraints in type parameters need to be the last constraint.

Solution

Added an OrderBy() to ensure that the new constraint ends up last. I haven't checked that the order of the other constraints remains the same, but I assume it does.

  • At least one test covering the code changed
  • All tests pass

@GrahamTheCoder GrahamTheCoder merged commit 45de45c into icsharpcode:master Apr 8, 2019

@GrahamTheCoder

This comment has been minimized.

Copy link
Member

GrahamTheCoder commented Apr 8, 2019

First PR merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.