Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Convert short literals in ternary expressions [#363] #412
Short literals in ternary expressions were not converted.
There were a couple of things here - we need to add conversions for each branch of the ternary opeartor. We could probably be more clever about this, but just adding the conversion is easy enough.
The other thing is the conversion of VB short literals. I added a case to the conversion analysis code to handle this - another (more invasive) approach would be to add an explicit case whenever we convert a VB literal that has an explicit suffix.
I reran and it passed, and it works locally too. I recently allowed files to be converted in parallel, so it just happened to show up this race condition. It wasn't anything to do with your PR, but since we saw it here and it's a tiny fix I've added it on the end.