Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer renamed imports for symbol resolution [#401] #415

Closed
wants to merge 1 commit into from

Conversation

@mrmonday
Copy link
Contributor

mrmonday commented Nov 12, 2019

Fixes #401

Problem

Renamed imports are removed when they match an import that's added automatically.

Solution

If there are multiple imports of the same namespace, prefer the import with an alias, and use that for name resolution.

  • At least one test covering the code changed
@mrmonday

This comment has been minimized.

Copy link
Contributor Author

mrmonday commented Nov 12, 2019

Oooh, ok, this actually depends on #414. I'll close this and merge the changes in.

@mrmonday mrmonday closed this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.