Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure class constructors are marked as public [#422] #425

Merged

Conversation

@mrmonday
Copy link
Contributor

mrmonday commented Nov 15, 2019

Fixes #422

Problem

Class constructors with no modifiers in VB need to be explicitly marked as public in C#.

Solution

  • At least one test covering the code changed
@GrahamTheCoder GrahamTheCoder merged commit 45fa282 into icsharpcode:master Nov 17, 2019
2 checks passed
2 checks passed
icsharpcode.CodeConverter Build #20191117.1 succeeded
Details
icsharpcode.CodeConverter (Job Config_Release) Job Config_Release succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.