Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object initializers, nullables and awaits #438

Merged
merged 14 commits into from Nov 25, 2019
Merged

Object initializers, nullables and awaits #438

merged 14 commits into from Nov 25, 2019

Conversation

@GrahamTheCoder
Copy link
Member

GrahamTheCoder commented Nov 23, 2019

  • Exit Function
  • Imitate what CType(blahString, MyEnum) does in IL
  • Object initializer should apply type conversions (e.g. enum to int)
  • Now should go to DateAndTime.Now
  • Ensure async keyword transferred on async lambdas
  • If statement should be coalesced from nullable to bool. Check what "Not" operator does to a nullable bool
@GrahamTheCoder GrahamTheCoder self-assigned this Nov 23, 2019
@GrahamTheCoder GrahamTheCoder force-pushed the minor-fixes-2 branch 2 times, most recently from 19d301c to ded97d3 Nov 23, 2019
@GrahamTheCoder GrahamTheCoder force-pushed the minor-fixes-2 branch from 3483e6d to 0af5715 Nov 25, 2019
@GrahamTheCoder GrahamTheCoder merged commit d366841 into master Nov 25, 2019
2 checks passed
2 checks passed
icsharpcode.CodeConverter Build #20191125.3 succeeded
Details
icsharpcode.CodeConverter (Job Config_Release) Job Config_Release succeeded
Details
@GrahamTheCoder GrahamTheCoder deleted the minor-fixes-2 branch Nov 25, 2019
@@ -24,6 +24,26 @@ All notable changes to the code converter will be documented here.
* Correctly convert ambiguous names ([#332](https://github.com/icsharpcode/CodeConverter/pull/332))
* Ensure correct visibility for constructors ([#422](https://github.com/icsharpcode/CodeConverter/pull/422))
* Ensure casing is correct for namespaces ([#421](https://github.com/icsharpcode/CodeConverter/pull/421))
* Convert implicit object->string cast correctly (#365)

This comment has been minimized.

Copy link
@mrmonday

mrmonday Nov 25, 2019

Contributor

Think you found the downside to merge=union here, @GrahamTheCoder 😉

This comment has been minimized.

Copy link
@GrahamTheCoder

GrahamTheCoder Nov 25, 2019

Author Member

Ah yes. I'll fix it on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.