New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "private protected" support #1010

Merged
merged 18 commits into from Dec 21, 2017

Conversation

Projects
None yet
3 participants
@pentp
Contributor

pentp commented Dec 12, 2017

This fixes "private protected" display for C# 7.2.

@dgrunwald dgrunwald referenced this pull request Dec 13, 2017

Open

C# language support status #829

46 of 75 tasks complete

@siegfriedpammer siegfriedpammer added this to the 3.1 milestone Dec 13, 2017

@siegfriedpammer

This comment has been minimized.

Show comment
Hide comment
@siegfriedpammer

siegfriedpammer Dec 14, 2017

Member

Thank you for you pull request, while the changes look quite good, we haven't yet decided how to deal with testing/implementing C# 7+ features, we now have to pull forward an internal architecture discussion. Please note this might take a while.

Note: before accepting your PR we would ask you to add some unit tests, but as mentioned above we haven't yet decided on how we want to handle testing multiple versions of Roslyn / language versions. So, currently adding unit tests would only break the build. We will update you as soon as we've implemented proper support for testing > C# 7.0 features.

Member

siegfriedpammer commented Dec 14, 2017

Thank you for you pull request, while the changes look quite good, we haven't yet decided how to deal with testing/implementing C# 7+ features, we now have to pull forward an internal architecture discussion. Please note this might take a while.

Note: before accepting your PR we would ask you to add some unit tests, but as mentioned above we haven't yet decided on how we want to handle testing multiple versions of Roslyn / language versions. So, currently adding unit tests would only break the build. We will update you as soon as we've implemented proper support for testing > C# 7.0 features.

@siegfriedpammer

This comment has been minimized.

Show comment
Hide comment
@siegfriedpammer

siegfriedpammer Dec 19, 2017

Member

Note: I will add some unit tests and then merge your PR.

Member

siegfriedpammer commented Dec 19, 2017

Note: I will add some unit tests and then merge your PR.

@siegfriedpammer siegfriedpammer merged commit 4ed1531 into icsharpcode:master Dec 21, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@siegfriedpammer

This comment has been minimized.

Show comment
Hide comment
@siegfriedpammer

siegfriedpammer Dec 21, 2017

Member

Thank you for your pull request!

Member

siegfriedpammer commented Dec 21, 2017

Thank you for your pull request!

@pentp pentp deleted the pentp:famandasm branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment