New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in source code (CWE-571) #789

Open
AppChecker opened this Issue Mar 29, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@AppChecker

AppChecker commented Mar 29, 2017

Hello!

We've checked your code with AppChecker static analyzer and found possible bug:

        internal static bool IsMemberEqual(MemberInfo m1,
                                           MemberInfo m2)
        {
            if (!m1.GetType().Equals(m1.GetType()))
                return false;
            if (!m1.DeclaringType.Equals(m2.DeclaringType))
                return false;
            if (!m1.Name.Equals(m2.Name))
                return false;
....
        }

m1.GetType() is compared with itself. We think it should be m2.GetType() instead

Possible defect was found by Echelon Team with AppChecker static analyzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment