New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SourceLink support #282

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
2 participants
@piksel
Collaborator

piksel commented Oct 27, 2018

This adds roughly 100KiB to the nuget package size but allows library consumers to get a full stack trace and step through the library code. This will hopefully help to give a better understanding about what happens when something goes wrong and allows for better issue descriptions.

Fixes #269

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@piksel piksel requested a review from christophwille Oct 27, 2018

@piksel piksel added this to the v1.1 milestone Oct 27, 2018

@christophwille

Size increase is not really a concern

@piksel piksel merged commit 0c5da44 into icsharpcode:master Oct 29, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@piksel piksel deleted the piksel:sourcelink branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment