Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a benchmarks project using BenchmarkDotNet #330

Merged
merged 1 commit into from Jun 15, 2019

Conversation

Projects
None yet
2 participants
@Numpsy
Copy link
Contributor

commented Mar 11, 2019

As I proposed in #328, this PR adds a benchmarks project using BenchmarkDotNet, with a few simple benchmarks for the CRC handling and zip input/output streams that i did when testing the proposed CRC changes and playing with .NET Core 3.

Could be useful for testing performance related changes in the future? It's a start anyway.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@piksel piksel self-assigned this May 22, 2019

@piksel

piksel approved these changes Jun 15, 2019

Copy link
Collaborator

left a comment

This is much better than having the performance tests. I'll look into integrating this with the CI.

@piksel piksel merged commit 1a12d9c into icsharpcode:master Jun 15, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Numpsy Numpsy deleted the Numpsy:benchmarkdotnet branch Jun 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.