Permalink
Commits on Oct 1, 2013
  1. Simple logging for some actions

    icy committed Oct 1, 2013
    * Delete, Upload image, Update image
Commits on Aug 30, 2013
  1. !bug: show two Edit buttons for :admin (piwigo 2.5)

    icy committed Aug 30, 2013
    Piwigo < 2.5 does not have this problem: When an image is editable,
    two Edit buttons will be displayed: One of IPM, the other is of
    native Piwigo. To fix this issue (remove our button), we will
    check if the current user is *admin. If *yes, just exit. Because
    we can not detect user information at the time the hooks are loaded,
    we need to detect user *inside* the hook contents. This will have
    a lot code, but it works.
    
    Please note that by removing IPM support from :admin, we will make
    thing clear, not messy anymore. When being enabled, IPM can prevent
    *admin* user from editting any image, but the native code allows
    them to edit images (confused!).
    
    I am not very sure why the previous Piwigo verions do not have this
    problem. Maybe the template system has changed. Better means buggy
  2. Bump new version 2.4.3

    icy committed Aug 30, 2013
  3. !bug: Windows CR/LF will break the parser

    icy committed Aug 30, 2013
    Due to strict regular expression the ZAML parser, and the $
    does not match any linefeed, the author name is ignored,
    and that is why any new setting will go to :default section.
    
    We can fix this by change the regexp, or simplify :rtrim
    the input $line. The 2nd way is much simpler, right?
  4. !bug: invalid reference skips author setting

    icy committed Aug 30, 2013
    If there is an invalid reference in ZAML file, like
    
      some_user:
       foo: bar
      new_user: @invalid_user
       foo: not_bar
    
    then any setting for "new_user" will be ignored. Actually,
    the reference line is skipped, so "new_user" will have not
    any setting, while "some_user" (whose settings are above
    the reference line) will accept non-wanted settings, so
    
      some_user:
        foo: bar
        foo: not_bar
    
    and finally, the "some_user" will use "not_bar" for "foo".
    
    In pratice, this may be considered as a "feature", because
    in ZAML any invalid line is meanless and used by the last
    user. However, that is very confused thing. Let see this
    example: The "some_user" belongs to the group "~moderator",
    and we have in ZAML
    
      ~moderator:
        edit_image_of: any
      new_user: @some_user
    
    People may think this works. But it is not. This is because
    the referene "@some_user" doesn't expand at the time ZAML
    file is parsed (this is natural; the parser shouldn't depend
    on any back-end stuff).
    
    In this fix, we make sure that an invalid referene lince
    will not skip author setting. We do not fix expansion issue.
Commits on Aug 18, 2013
  1. + missing </a> tag for edit button

    icy committed Aug 18, 2013
    For some reason I did not provide a closing tag for
    the edit button, so some users will encounter problem
    when the page is displayed.
    
    Special thanks to Flop25 at gmail dot com
Commits on Aug 14, 2013
  1. + latest forum link (on Piwigo)

    icy committed Aug 14, 2013
  2. IPM-SA-2013-08-14 credit @Kalle

    icy committed Aug 14, 2013
  3. ChangeLog: make clear about list of affected versions

    icy committed Aug 14, 2013
    that should be upgraded or patched to resolve IPM-SA-2013-08-14
  4. Bump new version 2.4.1

    icy committed Aug 14, 2013
  5. + Patch file for IPM-SA-2013-08-14

    icy committed Aug 14, 2013
  6. Fix a serious bug that breaks ACL. Thanks to Kalle

    icy committed Aug 14, 2013
    We use a wrong JOIN command (left join instead of a inner join),
    that brings the highest permissions to a users. If there are some
    groups, the user can always get the permissions from the highest
    group. This is an effect of the use of LEFT-JOIN query.
    
    If you are using version >= 2.1.0 of this plugin, it is highly
    that you upgrade to the latest version. If you don"t want to upgrade,
    you can
    
    * Edit the file manually, by replacing the LEFT JOIN by JOIN.
      Please search and edit in the file
       plugins/icy_picture_modify/include/*.php
    * Apply a patch found from the source tree
       https://github.com/icy/icy_picture_modify/tree/master/patches/
      (Find your version and patch file "IPM-SA-2013-08-14.patch"
    
    I hate PHP :)
Commits on Aug 13, 2013
  1. Fix typo in README

    icy committed Aug 13, 2013
  2. Bump new version 2.4.0

    icy committed Aug 13, 2013
  3. Update doc. to reflect new feature of :do_of

    icy committed Aug 13, 2013
    (allow to specify group name in values of :_of variables)
  4. icy_acl: + allow :do_of to acts on group images

    icy committed Aug 13, 2013
    New feature allows manager to provide groups in list of authors,
    example: edit_image_of: Testing, here :Testing is a group name
Commits on Aug 12, 2013
  1. README: + security notes

    icy committed Aug 12, 2013
Commits on Mar 23, 2013
  1. Add language support.

    icy committed Mar 23, 2013
    The plugin now has its own language directory copied from the plugin photo_update
    bc the fuction of photo_update can be replaced by the alternative function in our
    plugin. anyway, if the plugin photo_update is enabled, its language support will
    be loaded to our plugin.
    
    We also load language support from the plugin "community".
  2. Fix note

    icy committed Mar 23, 2013
  3. Add more notes to README

    icy committed Mar 23, 2013
Commits on Mar 19, 2013
  1. Fix typo

    icy committed Mar 19, 2013
    A very clear typo in section title :Licnese =))
  2. Fix typo

    icy committed Mar 19, 2013
  3. Update README

    icy committed Mar 19, 2013
Commits on Mar 16, 2013
  1. Support Piwigo 2.5.0

    icy committed Mar 16, 2013
    Add a workaround to support Piwigo 2.5. The default template of Piwigo
    does not contain `U_ADMIN` hence we have to add some specific HTML code
    (to template) from the main code without translation support.
Commits on Feb 8, 2013
  1. Merge branch 'hard_sub'

    icy committed Feb 8, 2013
  2. update doc

    icy committed Feb 8, 2013
  3. Merge branch 'hard_sub'

    icy committed Feb 8, 2013
  4. Add FIXME

    icy committed Feb 8, 2013
Commits on Dec 5, 2012
  1. Add new symbol :hard to modify :sub

    icy committed Dec 5, 2012
    By default, categories listing (and :sub) will ignore all forbidden categories.
    Because the permission of an album in Piwigo does not fully inherit its parent
    permissions, the Piwigo behavior may prevent some new sub-albums from being
    accessible by group members. See for example
       http://piwigo.org/forum/viewtopic.php?pid=137575#p137575
    By using this directive :hard, all forbidden categories are unhidden, hence
    this almost override settings from Piwigo system. This may lead to confusion
    and some difference between Piwigo settings (via WebConsole) and this plugin.
    However, let us see how it helps.
  2. Add security notes

    icy committed Dec 5, 2012