New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash fix when starting up Doom Classic; sprnames list must be NULL-terminated #1

Merged
merged 1 commit into from Nov 27, 2012

Conversation

Projects
None yet
3 participants
@JamesDunne
Contributor

JamesDunne commented Nov 27, 2012

Fixes a reproducible crash when built with VS2012 Premium in Debug and Retail builds.

BrianHarris pushed a commit that referenced this pull request Nov 27, 2012

Brian Harris
Merge pull request #1 from JamesDunne/sprnames-fix
Crash fix when starting up Doom Classic; sprnames list must be NULL-terminated

@BrianHarris BrianHarris merged commit be311f4 into id-Software:master Nov 27, 2012

DanielGibson pushed a commit to DanielGibson/DOOM-3-BFG that referenced this pull request Dec 1, 2012

Merge pull request #1 from DanielGibson/rb_static-rt
Use static runtime, remove 2 annoying assertions
@revelator

This comment has been minimized.

Show comment
Hide comment
@revelator

revelator Dec 2, 2012

Can change the (const char * const)NULL to '\0' works just as well and no need for a cast :)

Can change the (const char * const)NULL to '\0' works just as well and no need for a cast :)

This comment has been minimized.

Show comment
Hide comment
@JamesDunne

JamesDunne Dec 2, 2012

Contributor

No I don't think it would, but stranger things have been known to happen. The code is searching for a NULL pointer value to terminate the list, not a pointer to a string containing a 0 character.

Contributor

JamesDunne replied Dec 2, 2012

No I don't think it would, but stranger things have been known to happen. The code is searching for a NULL pointer value to terminate the list, not a pointer to a string containing a 0 character.

This comment has been minimized.

Show comment
Hide comment
@revelator

revelator Dec 2, 2012

Im not sure why but it works fine though it may not be 100% correct.
Though a lot of compilers treat '\0' the same way as a const integral 0 atleast according to many discussions on the matter.

Compilers are indeed strange ;)

Im not sure why but it works fine though it may not be 100% correct.
Though a lot of compilers treat '\0' the same way as a const integral 0 atleast according to many discussions on the matter.

Compilers are indeed strange ;)

@JamesDunne

This comment has been minimized.

Show comment
Hide comment
@JamesDunne

JamesDunne Dec 2, 2012

Contributor

Oh I see what you're saying, the '\0' character, not a "\0" string. Then yeah, that would work.

Contributor

JamesDunne commented Dec 2, 2012

Oh I see what you're saying, the '\0' character, not a "\0" string. Then yeah, that would work.

CarlKenner pushed a commit to CarlKenner/DOOM-3-BFG that referenced this pull request Dec 28, 2016

CarlKenner added a commit to CarlKenner/DOOM-3-BFG that referenced this pull request Dec 31, 2016

Merge pull request #1 from CarlKenner/fix-map33-betray
Fix Doom 3 BFG's broken Doom 2 MAP33 Betray.

CarlKenner pushed a commit to CarlKenner/DOOM-3-BFG that referenced this pull request Jan 1, 2017

Merge pull request #1 from CarlKenner/SamsonShrinkVideoDiscs
Make video discs 1/4 the normal size, & touch the desk, to look realistic in VR

CarlKenner pushed a commit to CarlKenner/DOOM-3-BFG that referenced this pull request Jul 10, 2018

Merge pull request #1 from KozGit/master
Keep up with new changes in main repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment