Improve name of InputParameters::registerBase

[aeslaughter]

Reason

In #14871 a new function (registerSystemAttributeName) was added to the InputParameters object to associate an object with the system the object should be executed with, e.g., UserObjects or Samplers. The registerBase function should be renamed to something more explicit.

Design

Deprecate registerBase and replace it with registerSyntaxName or something else?

Impact

Minimal, users will get a deprecated message, but this fix will be a simple name change.

[permcody]

registerSyntaxName is not what this is though. It needs to be lined up with the base class (the pluggable system). It has nothing to do with syntax. Maybe registerMooseSystem, registerPluggableSystem?

[aeslaughter]

It is connected to syntax via the MooseObjectAction that is allowed to build an object.

moose/framework/src/actions/ActionWarehouse.C

Line 146 in 383a82b

if (!_syntax.verifyMooseObjectTask(base, task))

[permcody]

No it's not:

Example:
"Diffusion" inherits from "Kernel", which has a registerBase call for the string "Kernel":

moose/framework/src/kernels/Kernel.C

Line 28 in 0896d7b

params.registerBase("Kernel");

So when you ask Diffusion what it's "base" is, it'll return "Kernel" (this isn't syntax, this is the "registeredBase" for an object).

Now the verifyMooseObjectTask compares this base with the what what kinds of MooseObjects the task (not the syntax) is registered to build:

moose/framework/src/base/Moose.C

Line 106 in 0896d7b

registerMooseObjectTask("add_kernel", Kernel, false);

So at the end of the day, when we find a "type = Diffusion" in the input file, the system is checking to make sure that the currently executing task is allowed to build those types of objects. It really doesn't have anything to do with syntax. I think the confusion comes from the fact that these errors come up when somebody messes up syntax: (e.g. if you put type = "Diffusion" in a [BCs] block) you get something about the object being constructed is in the wrong block.

[aeslaughter]

I think we are arguing symantics, I know that it isn't the syntax as in Diffusion. But, it certainly connects objects to input file syntax. Diffusion must be in [Kernels] etc., yes this happens through tasks, but practically it registerBase relates to input file block.

[aeslaughter]

It is not a direct relationship, but the two are certainly related:

registerSyntaxTask("AddKernelAction", "Kernels/*", "add_kernel");
registerMooseObjectTask("add_kernel",                   Kernel,                 false);