deprecated parameter in tests file appears to be ignored

[bwspenc]

Bug Description

There is a large set of tests of deprecated mesh_generator objects that are failing the deprecated test target, but they all have deprecated=true set in their tests file.

Steps to Reproduce

Look at any recent deprecated test target:
https://civet.inl.gov/job/524228/

Impact

We need this fixed to keep the deprecated test target passing. This isn't a hard fail, but this masks other issues that come up, so it needs to be fixed.

[bwspenc]

@milljm Maybe you're the best one to look into this?

[bwspenc]

Hmm... I guess I should have read the documentation for the deprecated parameter:

     deprecated                     = False                          # When True the test is no longer considered part SQA process and as such does not include the need for a requirement definition.

I would have thought that this would also turn on the no_error_deprecated behavior, but that doesn't seem to be the case. I guess we could turn this into a feature request and make it do that if people think that's a good idea.

[aeslaughter]

We should probably consolidation the "deprecated" and "no_deprecated_error"

[aeslaughter]

When running the tests with --error-deprecated it is possible to disable the warning to error conversion by using the "no_error_deprecated" in the test specification. For SQA purposes test specs with "deprecated = true" are exempt from needing requirements defined.

The "deprecated = true" should do both. I like this parameter because it is easier to read and type.