New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steady State Parameter Names #7145

Closed
friedmud opened this Issue Jun 2, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@friedmud
Contributor

friedmud commented Jun 2, 2016

Description of the enhancement or error report

The current Executioner parameter names for steady state detection are not the best and could use a good overhaul. They are currently:

trans_ss_check
ss_check_tol
ss_tmin

A few observations:

  • Why does one of them start with trans? It's inconsistent and it separates it from the others in Peacock (I always forget that I have to set it)
  • What does ss mean? Why not steady_state
  • Are we just "checking" it?
  • What does ss_tmin even mean?

I suggest:

steady_state_detection
steady_state_tolerance
steady_state_start_time

Rationale for the enhancement or information for reproducing the error

It's inconsistent currently... and hard to deduce for anyone new (or really anyone) what the options are for and hard to remember their name.

Identified impact

The old members can be deprecated for a while... they are used quite a bit so we can have a lengthy deprecation period. Since it's just changing the names it's not a problem to have both co-existing for a while.

@tophmatthews

This comment has been minimized.

Show comment
Hide comment
@tophmatthews

tophmatthews Jun 3, 2016

Contributor

+1
I always forget to set trans_ss_check since it doesn't start with ``ss`

Contributor

tophmatthews commented Jun 3, 2016

+1
I always forget to set trans_ss_check since it doesn't start with ``ss`

friedmud added a commit to friedmud/moose that referenced this issue Feb 8, 2018

friedmud added a commit to friedmud/moose that referenced this issue Feb 8, 2018

friedmud added a commit to friedmud/moose that referenced this issue Feb 8, 2018

friedmud added a commit to friedmud/moose that referenced this issue Feb 19, 2018

friedmud added a commit to friedmud/moose that referenced this issue Feb 19, 2018

@lindsayad lindsayad closed this in #10725 Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment