Fix regex in MOOSEDocs package extension #12611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Documentation on 4f3bd78 wanted to post the following: View the site here This comment will be updated on new commits. |
permcody
reviewed
Dec 17, 2018
| @@ -115,7 +115,7 @@ def defaultSettings(): | |||
|
|
|||
| def createToken(self, parent, info, page): | |||
| content = info['inline'] if 'inline' in info else info['block'] | |||
| content = re.sub(r'__(?P<package>[A-Z]+)__', self.subFunction, content, flags=re.UNICODE) | |||
| content = re.sub(r'__(?P<package>[A-Z\_]+)__', self.subFunction, content, flags=re.UNICODE) | |||
There was a problem hiding this comment.
You don't have to escape characters in character classes. In fact this might be slightly incorrect now because I believe it'll match A-Z and underscore and a backslash.
permcody
reviewed
Dec 17, 2018
| @@ -115,7 +115,7 @@ def defaultSettings(): | |||
|
|
|||
| def createToken(self, parent, info, page): | |||
| content = info['inline'] if 'inline' in info else info['block'] | |||
| content = re.sub(r'__(?P<package>[A-Z]+)__', self.subFunction, content, flags=re.UNICODE) | |||
| content = re.sub(r'__(?P<package>[A-Z\_]+)__', self.subFunction, content, flags=re.UNICODE) | |||
There was a problem hiding this comment.
You don't have to escape characters in character classes. In fact this might be slightly incorrect now because I believe it'll match A-Z and underscore and a backslash.
There was a problem hiding this comment.
I don't know why I "escaped" the underscore, I don't think it is ever needed.
permcody
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(refs #12528)