Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Makefiles for modules #13343

Merged
merged 4 commits into from May 2, 2019
Merged

Conversation

permcody
Copy link
Member

@permcody permcody commented May 1, 2019

No more specifying dependencies at the Makefile level
Fixes missing deps in the libraries when building individual modules

This will also fix the failures in the new Parallel Modules test:
https://civet.inl.gov/job/330190/

closes #13341

@moosebuild
Copy link
Contributor

moosebuild commented May 1, 2019

Job Documentation on 05bc123 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Modules debug on 74cc886 : invalidated by @permcody

@permcody permcody force-pushed the makefile_fixes branch 2 times, most recently from 331d7d0 to a6388e5 Compare May 2, 2019 15:53
No more specifying dependencies at the Makefile level
Fixes missing deps in the libraries when building individual modules

closes idaholab#13341
@moosebuild
Copy link
Contributor

Job Modules Parallel Test (In progress) on ed48729 : invalidated by @permcody

modules/modules.mk Outdated Show resolved Hide resolved
@andrsd andrsd added the PR: Auto Merge Add this label to have CIVET merge on success label May 2, 2019
@moosebuild moosebuild merged commit edcff0e into idaholab:next May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Auto Merge Add this label to have CIVET merge on success
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individual Makefile module libraries are still missing other module reps
3 participants