Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybridized finite elements #26477

Merged
merged 66 commits into from
May 21, 2024
Merged

Hybridized finite elements #26477

merged 66 commits into from
May 21, 2024

Conversation

lindsayad
Copy link
Member

@lindsayad lindsayad commented Jan 4, 2024 •
edited
Loading

Todo:

  • Documentation
  • framework level test

Closes #26405 #26406

@lindsayad lindsayad changed the title Hybridized finite elements [WIP] Hybridized finite elements Jan 4, 2024
@lindsayad
Copy link
Member Author

requires a libmesh update

This was referenced Jan 4, 2024
Merged
Merged
@lindsayad lindsayad changed the title [WIP] Hybridized finite elements Hybridized finite elements Jan 30, 2024
@lindsayad lindsayad mentioned this pull request Jan 31, 2024
Closed
@moosebuild
Copy link
Contributor

moosebuild commented Jan 31, 2024 •
edited
Loading

Job Documentation on bb6387e wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Modules parallel on fc7dc8d : invalidated by @lindsayad

@moosebuild
Copy link
Contributor

moosebuild commented Feb 12, 2024 •
edited
Loading

Job Coverage on bb6387e wanted to post the following:

Framework coverage

4d05a1 #26477 bb6387
Total Total +/- New
Rate 85.10% 85.14% +0.04% 92.66%
Hits 103260 103789 +529 644
Misses 18085 18122 +37 51

Diff coverage report

Full coverage report

Modules coverage

Fluid properties

4d05a1 #26477 bb6387
Total Total +/- New
Rate 85.47% 85.47% - 100.00%
Hits 7261 7261 - 1
Misses 1234 1234 - 0

Diff coverage report

Full coverage report

Navier stokes

4d05a1 #26477 bb6387
Total Total +/- New
Rate 83.87% 84.17% +0.30% 97.07%
Hits 15981 16412 +431 431
Misses 3073 3086 +13 13

Diff coverage report

Full coverage report

Phase field

4d05a1 #26477 bb6387
Total Total +/- New
Rate 85.69% 85.69% - 100.00%
Hits 13187 13187 - 1
Misses 2203 2203 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@lindsayad lindsayad marked this pull request as ready for review February 15, 2024 16:10
@GiudGiud
Copy link
Contributor

Can we narrow down the name? Maybe HybridDG?

@lindsayad
Copy link
Member Author

I suppose

@lindsayad
Copy link
Member Author

lindsayad commented May 15, 2024 •
edited
Loading

Hopefully ready again

@idaholab idaholab deleted a comment from moosebuild May 19, 2024
GiudGiud
GiudGiud approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

lindsayad and others added 2 commits May 20, 2024 07:48
@lindsayad
Swap qp and ij loop ordering where easy
9acbf23
@lindsayad @GiudGiud
Address elements of Guillaume review
dcbeb48 
- More doxygen
- Documentation corrections
- Note on LDG vs. IP methods

Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
@lindsayad lindsayad requested a review from grmnptr May 20, 2024 19:55
@lindsayad
Use functor for pressure mms function
bb6387e 
Allows removal of TransientInterface::time
@lindsayad lindsayad mentioned this pull request May 21, 2024
Merged
grmnptr
grmnptr approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@grmnptr grmnptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice new capability!

@lindsayad lindsayad merged commit f91337a into idaholab:next May 21, 2024
49 checks passed
@lindsayad lindsayad deleted the hdg branch May 21, 2024 19:39
@roystgnr roystgnr mentioned this pull request Jul 16, 2024
Open
roystgnr added a commit to roystgnr/moose that referenced this pull request Jul 16, 2024
@roystgnr
Prerequest curl iff we _need_curl
cf02ad6 
Refs idaholab#28153

This fixes a bug similar to the bug described in idaholab#28153 - I think that
bug may have been fixed in idaholab#26477 ...
N4hom pushed a commit to N4hom/moose that referenced this pull request Jul 30, 2024
@roystgnr @N4hom
Prerequest curl iff we _need_curl
6d2c765 
Refs idaholab#28153

This fixes a bug similar to the bug described in idaholab#28153 - I think that
bug may have been fixed in idaholab#26477 ...
TheGreatCid pushed a commit to TheGreatCid/moose that referenced this pull request Aug 1, 2024
@roystgnr @TheGreatCid
Prerequest curl iff we _need_curl
984dc93 
Refs idaholab#28153

This fixes a bug similar to the bug described in idaholab#28153 - I think that
bug may have been fixed in idaholab#26477 ...
TheGreatCid pushed a commit to TheGreatCid/moose that referenced this pull request Aug 14, 2024
@roystgnr @TheGreatCid
Prerequest curl iff we _need_curl
270b7b8 
Refs idaholab#28153

This fixes a bug similar to the bug described in idaholab#28153 - I think that
bug may have been fixed in idaholab#26477 ...
Leni-Yeo pushed a commit to Leni-Yeo/moose that referenced this pull request Aug 28, 2024
@roystgnr
Prerequest curl iff we _need_curl
632b7f7 
Refs idaholab#28153

This fixes a bug similar to the bug described in idaholab#28153 - I think that
bug may have been fixed in idaholab#26477 ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiudGiud GiudGiud GiudGiud approved these changes

@grmnptr grmnptr grmnptr approved these changes

@dschwen dschwen Awaiting requested review from dschwen dschwen is a code owner

@roystgnr roystgnr Awaiting requested review from roystgnr roystgnr is a code owner

@joshuahansel joshuahansel Awaiting requested review from joshuahansel joshuahansel is a code owner

Assignees

@lindsayad lindsayad

Labels
PR: Ready for review/merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement hybridized discontinuous galerkin (HDG) Navier-Stokes
4 participants
@lindsayad @moosebuild @GiudGiud @grmnptr