Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parallel mesh in MultiAppNearestNodeTransfer #5360

Merged
merged 1 commit into from Jul 14, 2015

Conversation

Projects
None yet
4 participants
@smharper
Copy link
Contributor

commented Jul 9, 2015

This PR makes a pretty significant overhaul of MultiAppNearestNodeTransfer. From the user's perspective, the only difference is that it now works with parallel meshes. From our perspective, I hope it's a little cleaner because it now uses execute() without very much specialization for to_multiapp/from_multiapp. It also lays some groundwork for refactoring transfers to use more methods from the MultiAppTransfer base class.

The transfer now uses an MPI algorithm very similar to the one in #5260. It might also offer a performance gain for runs with large meshes and lots of processors because processor bounding boxes are used to narrow down the number of nodes each processor must search.

Also note that _displaced_source_mesh and _displaced_target_mesh have been moved to MultiAppTransfer. I did that so that MultiAppTransfer can make the appropriate meshes available to inherited classes. But displaced meshes don't make since for all of the sub classes so displaced_*_mesh isn't included MultiAppTransfer; it's up to the sub classes to make that parameter and adjust the displaced_*_mesh variables.

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2015

Results of testing 333fb36 using moose_PR_pre_check recipe:

Failed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19199

@smharper smharper force-pushed the smharper:nearest_node_parallel_mesh branch from 333fb36 to 8e67880 Jul 9, 2015

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2015

Results of testing 8e67880 using moose_PR_pre_check recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19203

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2015

Results of testing 8e67880 using moose_PR_app_tests recipe:

Failed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19206

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2015

Results of testing 8e67880 using moose_PR_test recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19204

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2015

Results of testing 8e67880 using moose_PR_test_dbg recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19205

@smharper smharper force-pushed the smharper:nearest_node_parallel_mesh branch from 8e67880 to 34ffd44 Jul 9, 2015

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2015

Results of testing 34ffd44 using moose_PR_pre_check recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19212

*/
Real bboxMinDistance(Point p, MeshTools::BoundingBox bbox);

std::vector<Node *> getLocalNodes(MooseMesh * mesh);

This comment has been minimized.

Copy link
@jwpeterson

jwpeterson Jul 9, 2015

Member

This returns a copy of a vector and you call it in a loop... It may be more efficient to have this function take a reference to a std::vector<Node*> provided by the user. This will cut down on some vector allocations/deallocations.

This comment has been minimized.

Copy link
@smharper

smharper Jul 13, 2015

Author Contributor

Fixed

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2015

Results of testing 34ffd44 using moose_PR_app_tests recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19215

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2015

Results of testing 34ffd44 using moose_PR_test recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19213

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2015

Results of testing 34ffd44 using moose_PR_test_dbg recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19214

@smharper smharper force-pushed the smharper:nearest_node_parallel_mesh branch from 34ffd44 to a9f6751 Jul 13, 2015

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2015

Results of testing a9f6751 using moose_PR_pre_check recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19271

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2015

Results of testing a9f6751 using moose_PR_app_tests recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19274

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2015

Results of testing a9f6751 using moose_PR_test recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19272

@moosebuild

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2015

Results of testing a9f6751 using moose_PR_test_dbg recipe:

Passed on: linux-gnu

View the results here: https://www.moosebuild.org/view_job/19273

@permcody

This comment has been minimized.

Copy link
Member

commented Jul 14, 2015

Nice work 👍

permcody added a commit that referenced this pull request Jul 14, 2015

Merge pull request #5360 from smharper/nearest_node_parallel_mesh
Allow parallel mesh in MultiAppNearestNodeTransfer

@permcody permcody merged commit 62657bf into idaholab:devel Jul 14, 2015

1 check passed

default Successfully passed all tests
Details

@smharper smharper deleted the smharper:nearest_node_parallel_mesh branch Jul 14, 2015

smharper added a commit to smharper/moose that referenced this pull request Jul 15, 2015

smharper added a commit to smharper/moose that referenced this pull request Jul 15, 2015

smharper added a commit to smharper/moose that referenced this pull request Jul 16, 2015

smharper added a commit to smharper/moose that referenced this pull request Jul 17, 2015

smharper added a commit to smharper/moose that referenced this pull request Jul 17, 2015

smharper added a commit to smharper/moose that referenced this pull request Jul 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.