Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Write tests for OAuth1 Client class #28

Closed
idan opened this Issue May 1, 2012 · 1 comment

Comments

Projects
None yet
2 participants
Owner

idan commented May 1, 2012

No description provided.

Collaborator

ib-lundgren commented Nov 16, 2012

There are many things that would be useful to add as tests. On top of my head ...

  • Tests serve as great documentation, show off the different signature methods with tests, i.e. rsa and plaintext.
  • Requests with application/x-www-form-urlencoded, ensure it affects the signature
  • Requests with non application/x-www-form-urlencoded, ensure it does not affect the signature. For examples see http://en.wikipedia.org/wiki/MIME_type
  • Possible run over a set of sample "real" requests with more complex combinations of query params, headers and body than the usual basic test.
  • Similar to the above would be to generate possible combinations of combinations with nonsensical but valid data and see if there are odd edge cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment