Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add link to readthedocs documentation. #70

Merged
merged 2 commits into from Nov 16, 2012

Conversation

Projects
None yet
4 participants
Contributor

tomchristie commented Nov 13, 2012

No description provided.

Contributor

tomchristie commented Nov 13, 2012

Note: The travis failure is just travis being wonky. There's no code changes here.

sontek commented Nov 13, 2012

There is a development branch, make the pull request against that instead of master

Contributor

tomchristie commented Nov 13, 2012

@sontek - Okay, I'm officially confused.

I don't see a development branch mentioned here https://oauthlib.readthedocs.org/en/latest/contributing.html or from the README.

The latest set of merged pull reqs were against master, eg: #69, #67, #66

The branches against this project are named master, oauth2_provider, oauth2_draft25_server, use_request_objects, it's not obvious which of these you're referring to.

Collaborator

ib-lundgren commented Nov 14, 2012

Thanks for the PR =) I think "All documentation is available at Read the Docs." might read better. Just a nitpick, feel free to disagree.

Since "all docmentation" is rather limited I now need to find a way to lure you into writing some docs...

Collaborator

kennethreitz commented Nov 16, 2012

thanks!

kennethreitz added a commit that referenced this pull request Nov 16, 2012

Merge pull request #70 from tomchristie/master
Add link to readthedocs documentation.

@kennethreitz kennethreitz merged commit fa15533 into idan:master Nov 16, 2012

1 check failed

default The Travis build failed
Details

ib-lundgren added a commit that referenced this pull request Nov 16, 2012

Merge pull request #71 from tomchristie/master
Tweak README as requested in #70.
Contributor

tomchristie commented Nov 16, 2012

Since "all docmentation" is rather limited I now need to find a way to lure you into writing some docs...

@ib-lundgren @kennethreitz - I have considered contributing, but I think it'd be more like to be in the form of helping maintain a Django implementation, ideally also contributing compatible auth classes to django-rest-framework and django-tastypie to help converge the community on a single well documented and well maintained implementation.

I don't know whether that's pre-mature at the moment, and I'm a bit unsure what the current state of the project is...

  • Should I consider OAuth1 useable yet?
  • Will the OAuth2 server API be different or are all the differences implementation-only?
  • Are there many/any well maintained implementations using this yet, or anyone else planning a Django implementation?
    I see https://github.com/craigbruce/django-oauth, but It's not clear how complete that currently is.
Collaborator

ib-lundgren commented Nov 16, 2012

Even better! I've long had a wish to start a django implementation myself but I have not and will not have time to anytime soon.

Should I consider OAuth1 useable yet?

I think OAuth1 is usable and the next step really is to get some implementations going to weed out the remaining quirks and features needed.

Will the OAuth2 server API be different or are all the differences implementation-only?

OAuth2 is quite different from OAuth 1 in that it supports a great many more variations of obtaining tokens as well as types of tokens. I'm working quite actively on OAuth 2 provider support in the oauth2_provider branch but it needs a fair amount of work before it is complete.

I'm not sure whether you would want to mix OAuth 1 and 2 in the same extension or whether it makes more sense to split it into django-oauth and django-oauth2. It certainly is possible to mix them and differentiate between oauth 1 & 2 requests. Django more or less enforcing users to use their ORM makes creating a fully working drop-in oauth (1 or 2) provider extension possible. It could basically boil down to users simply decorating the views they want to protect and configure an authorization page.

Are there many/any well maintained implementations using this yet, or anyone else planning a Django implementation? I see https://github.com/craigbruce/django-oauth, but It's not clear how complete that currently is.

I'm fairly oblivious to who are actually using OAuthLib and do not really know of any (first time i see the one you mention there). If you have time to do some research into whats available and contact those working on various implementations in order to join efforts that would be super awesome. I would love to collaborate more closely with people using OAuthLib, especially for the purpose of providing OAuth. * note to self - encourage people to get in touch somewhere *.

Let me know if you'd like to have a chat over a G+ hangout to discuss this in more detail.

Cheers

Contributor

tomchristie commented Nov 16, 2012

I fear I may be backing myself into a corner here ;)

Collaborator

ib-lundgren commented Nov 16, 2012

Hehe, no pressure =) All contributions are much appreciated, dig in where it seems most fun. I'll lurk around here, with a very varied response latency, in case you want to ball some ideas.

If an extension seems daunting I have a little coffee stained post-it note with issues I mean to add this weekend of various sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment