WIP WIP WIP #139
Closed
WIP WIP WIP #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 31, 2017 18:14
Having it in each and every role means that Ansible considers them separate handlers. As a result, Nginx can be restarted more than once at the end of a playbook.
Having it in each and every role means that Ansible considers them separate handlers. As a result, dnsmasq can be restarted more than once at the end of a playbook.
Having it in each and every role means that Ansible considers them separate handlers. As a result, tinc can be restarted more than once at the end of a playbook.
Having it in each and every role means that Ansible considers them separate handlers. As a result, tinc can be reloaded more than once at the end of a playbook.
Having it in each and every role means that Ansible considers them separate handlers. As a result, uWSGI can be restarted more than once at the end of a playbook. When it starts, uWSGI runs the Ideascube app, which runs collectstatic. Because the uWSGI service is `Type=forking`, systemd considers uWSGI finished started when the parent process exits. But that happens long before collectstatic finished running. As a result, it is possible that Ansible will restart uWSGI twice in a row, while the first one was still running collectstatic. We think this is what could cause a weird Ideascube bug: https://framagit.org/ideascube/ideascube/issues/829
If we were right about the fact that the Ideascube bug was created by the multiple restarts of uWSGI (see previous commit), then this is now unnecessary.
And it seems I was wrong. 😞 |
|
Closing this, because it's completely useless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm about 75% confident that the commit in this branch related to uWSGI should fix https://framagit.org/ideascube/ideascube/issues/829.
This pull request only factorizes the handlers I found defined multiple times throughout the roles.
In general, it would probably be a good idea to define all the handlers at the top level, to avoid this kind of duplication in the future?