New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHAREKIT 2.0 – ONE MAIN GLOBAL FORK #283

Open
SlavaBushtruk opened this Issue Aug 3, 2011 · 56 comments

Comments

Projects
None yet
@SlavaBushtruk
Copy link

SlavaBushtruk commented Aug 3, 2011

Guys, I think it's time for ShareKit 2.0 managing only by community. So much good code was written, so much good features and fixes. That's really good!

But when I try to gather all these pieces from different forks .. it's just impossible.

We really need one common fork and mentors who will take care of pull requests.

Let's discuss?

@troppoli

This comment has been minimized.

Copy link

troppoli commented Aug 3, 2011

Best I can tell I have all of the common changes in my fork, as well as fixes for leaks, allow configurable sharers list (so that you can subclass SHKsharers), callbacks for canceling out of sharers, added UI for flickr and removed a round trip to the server to set item attributes, allow you to nobble offline and other enhancements.

Off the top I've merged flickr integration, delegate config, new facebook and many more.

I would be open to having other admins on my fork, and could spare a little time to merge changes, but I don't want to be the only one.

-s

@SlavaBushtruk

This comment has been minimized.

Copy link
Author

SlavaBushtruk commented Aug 3, 2011

This is really good! I see you're very active last time. Thank for the quick reply.

The main problem for ShareKit newbie is to select right fork. Then when any bug appears, e.g. Facebook doesn't share text right now, people try to fix and it's hard to find fixes and how to embed it in own changes code and so on. This becomes a mission impossible for newbies. So that's why I believe we need one fork and maybe ask @ideashower to delegate rights to new lead or so.

Honestly I am not very experienced in ShareKit, I just see my own problem and suggest that it's common.

Let's wait what other guys think.
I've sent a message @ideashower also.

@mvdnbrk

This comment has been minimized.

Copy link

mvdnbrk commented Aug 10, 2011

I agree with you that there should be one global fork.
It's getting pretty hard right now to get things up and running quickly.
There are a lot of enhancements fragmented over a lot of forks.

Apperently @ideashower doesn't have the time to maintain this fork.

If you guys need some help getting ShareKit to V2.0 I am willing to contribute to this project.

@postmechanical

This comment has been minimized.

Copy link

postmechanical commented Aug 18, 2011

This situation exemplifies the strength and weakness of open libs shared via GitHub. I suspect that ideashower is simply too busy to manage all the work that community is contributing and I suspect that would be the case for any individual or group who would take over. I would recommend that any beginner start with a fork of the jayway fork (https://github.com/jayway/ShareKit) and merge in other forks as needed.

@ened

This comment has been minimized.

Copy link

ened commented Aug 23, 2011

Hey there- interested to see ShareKit in the hands of the community as well. A little busy these days with projects and usually use Github to keep the changes / additions somewhere at least. A central repository on Github would be great.
We could think about a simple upvote procedure by a core team of ShareKit contributors which decides what goes into the main GH-Project or not.

What is the next step to continue?

@scompt

This comment has been minimized.

Copy link

scompt commented Aug 24, 2011

I think this is a great idea. I sent message to @ideashower 5 months ago suggesting this and never got a response back.

I've created a GitHub organization called ShareKit and pushed the current contents of the repo there. I have no problem giving others admin rights to the org.

I think the next step should be deciding on a fork that will become the seed of ShareKit 2.0. It might also be useful to port the current issues from ideashower to the new org.

https://github.com/ShareKit/ShareKit

@troppoli

This comment has been minimized.

Copy link

troppoli commented Aug 24, 2011

I've spent a fair amount of time merging all of the best changes into my fork. I've even fixed some long standing memory leaks and added enhancements to contributed elements.
https://github.com/troppoli/ShareKit
We are using this fork in our products and will do so for the foreseeable future.
-s


From: "scompt" reply@reply.github.com
Sent: Wednesday, August 24, 2011 3:22 AM
To: steve@eastcoastpixels.com
Subject: Re: [ShareKit] SHAREKIT 2.0 - ONE MAIN GLOBAL FORK (#283)

I think this is a great idea. I sent message to @ideashower 5 months ago suggesting this and never got a response back.

I've created a GitHub organization called ShareKit and pushed the current contents of the repo there. I have no problem giving others admin rights to the org.

I think the next step should be deciding on a fork that will become the seed of ShareKit 2.0. It might also be useful to port the current issues from ideashower to the new org.

https://github.com/ShareKit/ShareKit

Reply to this email directly or view it on GitHub:
#283 (comment)

@coneybeare

This comment has been minimized.

Copy link

coneybeare commented Aug 24, 2011

Whichever fork is used, I do recommend a "rebase" by putting it on the ShareKit/ShareKit tree. It will minimize confusion for users in the long run as to which branch is the "official" one, and can serve as the root for the 2.0 going forward. @troppoli @scompt

@clozach

This comment has been minimized.

Copy link

clozach commented Aug 31, 2011

I'd like to contribute, with the caveat that a) I still haven't grokked git and am therefore of limited use as an admin and b) I'm completely new to ShareKit.

  • @scompt, if you add me to the ShareKit org, I'd be happy to start participating by rewriting the ReadMe to summarize the discussion happening here.
  • After perusing the commit histories of the two forks mentioned so far, it seems likely that @troppoli has the stronger repo. If given privileges on ShareKit/ShareKit, I'd like to follow @coneybeare 's recommendation and (after figuring out how), rebase to https://github.com/troppoli/ShareKit.

Unless there's a good argument against either of these next steps...?

-C

@clozach

This comment has been minimized.

Copy link

clozach commented Aug 31, 2011

P.S. One thing that surprises me is that the ShareKit/ShareKit network graph is completely disconnected from the original. It seems like that might make it harder to pull useful commits from all of the existing project forks. (?)

@troppoli

This comment has been minimized.

Copy link

troppoli commented Aug 31, 2011

There are a ton of forks that have become less and less compatible. I think that my fork as the bulk of the changes that people have been looking for and some fixes to fundamental issues.

@coneybeare

This comment has been minimized.

Copy link

coneybeare commented Aug 31, 2011

@troppoli, can you and @scompt work together to get on a more official repo with your code at ShareKit/ShareKit ?

@scompt

This comment has been minimized.

Copy link

scompt commented Aug 31, 2011

@clozach That's true. I pulled locally and then pushed up to github, which blew away the network graph. The one benefit that it has is that it doesn't say 'forked from ...', which might lend the repo some credibility as the canonical one. What are the others' opinion about this? Fork with network graph or pull/push without network graph?

Let's go with @troppoli 's repository in any case. That'll get us up and running with a good base from which we can start looking at the existing tickets to see which should be ported.

@troppoli

This comment has been minimized.

Copy link

troppoli commented Sep 1, 2011

If you pull and push, you loose the history of where changes came from, what changes are in and the comments from the checkins. I think that they are too valuable to loose.
-s


From: "scompt" reply@reply.github.com
Sent: Wednesday, August 31, 2011 5:10 PM
To: steve@eastcoastpixels.com
Subject: Re: [ShareKit] SHAREKIT 2.0 - ONE MAIN GLOBAL FORK (#283)

@clozach That's true. I pulled locally and then pushed up to github, which blew away the network graph. The one benefit that it has is that it doesn't say 'forked from ...', which might lend the repo some credibility as the canonical one. What are the others' opinion about this? Fork with network graph or pull/push without network graph?

Let's go with @troppoli 's repository in any case. That'll get us up and running with a good base from which we can start looking at the existing tickets to see which should be ported.

Reply to this email directly or view it on GitHub:
#283 (comment)

@coneybeare

This comment has been minimized.

Copy link

coneybeare commented Sep 1, 2011

You can have both. http://gbayer.com/development/moving-files-from-one-git-repository-to-another-preserving-history/ This was the first google hit, I am sure there are other ways too.

@troppoli, it needs to be off of your personal fork to get any legs here as an "official" 2.0

@troppoli

This comment has been minimized.

Copy link

troppoli commented Sep 1, 2011

I've never done that but it looks promising.

On Aug 31, 2011, at 8:24 PM, coneybeare reply@reply.github.com wrote:

You can have both. http://gbayer.com/development/moving-files-from-one-git-repository-to-another-preserving-history/

@troppoli, it needs to be off of your personal fork to get any legs here as an "official" 2.0

Reply to this email directly or view it on GitHub:
#283 (comment)

@scompt

This comment has been minimized.

Copy link

scompt commented Sep 1, 2011

I've re-pushed the ShareKit/ShareKit repository using the method described in @coneybeare 's linke (essentially clone/push instead of pull/push). The history is there, but the network isn't. Is that enough to go on? I used @troppoli 's fork this time.

@clozach I've just created the wiki for the repository. Let's stick the documentation in there. You should be able to edit it.

@benjaminjackson

This comment has been minimized.

Copy link

benjaminjackson commented Sep 1, 2011

Count me in, people. I should note that I've already added iOS[REDACTED] support for SHKTwitter.

@troppoli

This comment has been minimized.

Copy link

troppoli commented Sep 1, 2011

@coneybeare well I just pushed to sharekit/troppoli and tried to open a pull request to sharekit/sharekit... not sure how to do it because of the way it was created. Any ideas?

@coneybeare

This comment has been minimized.

Copy link

coneybeare commented Sep 1, 2011

I am not entirely sure, but because ShareKit/Sharekit has your recent code, I think it would be easiest to create a new branch off of that, re-apply the changes that you just pushed to sharekit/troppoli, then submit a pull request back up to ShareKit/ShareKit. @scompt should make you a collaborator on the main repo so you can accept your own pull requests and push to master there

@postmechanical

This comment has been minimized.

Copy link

postmechanical commented Sep 1, 2011

Which commit added the iOS[REDACTED] support?

@scompt

This comment has been minimized.

Copy link

scompt commented Sep 1, 2011

@troppoli I've just deleted the repo again and forked it using the normal methods. Try again with your pull request. I've also added you so that you can push to the repository.

@coneybeare Your issue got deleted when deleting and forking the repo. Can you add it again?

@coneybeare

This comment has been minimized.

Copy link

coneybeare commented Sep 1, 2011

@scompt forking from @troppoli is the wrong approach here.

  • AFAIK, You can't create issues in a fork, or have project management such as milestones, etc
  • It loses credibility with the "forked by" text
@troppoli

This comment has been minimized.

Copy link

troppoli commented Sep 1, 2011

As it turns out, the new fork has my latest change, so I can't initiate a pull, but I will on the next change.


From: "scompt" reply@reply.github.com
Sent: Thursday, September 01, 2011 4:46 PM
To: steve@eastcoastpixels.com
Subject: Re: [ShareKit] SHAREKIT 2.0 - ONE MAIN GLOBAL FORK (#283)

@troppoli I've just deleted the repo again and forked it using the normal methods. Try again with your pull request. I've also added you so that you can push to the repository.

@coneybeare Your issue got deleted when deleting and forking the repo. Can you add it again?

Reply to this email directly or view it on GitHub:
#283 (comment)

@scompt

This comment has been minimized.

Copy link

scompt commented Sep 2, 2011

@coneybeare I've just enabled issues for the repository. I think the rest of the project management stuff is also enabled with that feature. Do you notice anything else that is missing? That means the only downside is the lack of credibility. Personally, I think it would be better if it wasn't forked, but rather cloned as it was previously. I think the credibility issue is also important. However, I'm not sure what problem @troppoli had when trying to make his pull request and if it has to do with the way the repo was created.

@coneybeare

This comment has been minimized.

Copy link

coneybeare commented Sep 2, 2011

The problem was that @troppoli did not reclone from the sharekit/sharekit repo, then do the pull request. He tried to do the request across repo's. It has to be done as before, with you pulling the history from him, then him doing the process outlined in #283 (comment)

A new beginning, a 2.0 for share kit, really needs to be a fresh start, pulling from an up-to-date repo like @troppoli's to start with. I won't contribute to yet another fork based off of the 1.0, and I am sure there are many like me.

@SlavaBushtruk

This comment has been minimized.

Copy link
Author

SlavaBushtruk commented Sep 3, 2011

Guys, thanks everybody to be active! Sorry for late, I was on a vocation.
– please add me to the new repo
– yes, it's hard to decide from what which to start. I believe it's better to start just from one of more active. Just select and go. if it's @troppoli's one then I'm able to switch my project to it. More–more important to keep it active and centralized.
– I'm in!

– have you decided to organize a core team or work in Git style with personal forks and pull requests?

@benjaminjackson

This comment has been minimized.

Copy link

benjaminjackson commented Sep 4, 2011

@alondon: Not pushed yet, as the code is still under NDA and can't be made public.

@scompt

This comment has been minimized.

Copy link

scompt commented Sep 4, 2011

@coneybeare OK, that makes sense. I've re-done the repo using clone/push. Hopefully everything works now. Sorry to everyone who's tried to watch/comment/whatever on the repo while I've been getting this sorted out.

@SlavaBushtruk I've added you to the new repo. I'd be more for the git development style with personal forks.

Shall we move the discussion over to the new repo? I've just added a 2.0 milestone. Let's make a release!

@SlavaBushtruk

This comment has been minimized.

Copy link
Author

SlavaBushtruk commented Sep 4, 2011

Thanks!

So the best way to push changes is to make a new fork and the make pull request for you?

@SlavaBushtruk

This comment has been minimized.

Copy link
Author

SlavaBushtruk commented Sep 4, 2011

I made 3 issues in new repo to discuss. Just not sure how to notify you about it except this topic.

@clozach

This comment has been minimized.

Copy link

clozach commented Sep 5, 2011

I agree that development should be done in personal forks with pull requests as a primary method of integrating fixes. At the same time, a core team should have pull/push privileges on github.com/ShareKit, with at least 2-3 full owners. Not would more members reduce risk to the community at large, but it's more fair to the org. members since verifying pull requests, managing issues prioritization, and defining stable releases can be a lot of work!

@scompt, I'm sure you want to make sure that there aren't too many cooks in the kitchen, but please at least invite @troppoli in (if he wants), and me and/or @coneybeare (if you trust us) so that we can share the load. :) I'm cramming as much git/github info as I can fit into my tiny brain right now in order to become a useful resource on this project....

@scompt

This comment has been minimized.

Copy link

scompt commented Sep 5, 2011

I've added the following users as owners to the ShareKit/ShareKit repository. I think that should be a good start at a core team. We can make changes later if the need arises.

@coneybeare, @clozach, @troppoli, @SlavaBushtruk, @scompt

@mosesoak

This comment has been minimized.

Copy link

mosesoak commented Sep 6, 2011

It's great that you all are trying to resurrect this project but my current project timeline is tight, so I'm wondering - is there a fork out there where at least the FBConnect portion has been updated to use FB's latest API? Thanks!

@postmechanical

This comment has been minimized.

Copy link

postmechanical commented Sep 9, 2011

@benjaminjackson Was just curious whether the fix was a backwards compatible one that could be made with iOS 4.x. Figured it out anyway.

@lexar

This comment has been minimized.

Copy link

lexar commented Oct 4, 2011

Hello guys, could someone please explain from where I should get troppolis fork? From https://github.com/troppoli/ShareKit or from here? If from here, where do I find it? The files from https://github.com/ideashower/ShareKit are all from 2010.
Sorry for that newbie question, I am still confused with git forks/pulls/trunks etc...

Question 2 while I'm at it, does troppolis fork work with
-the latest facebook sdk?
-localization, as described here -> #94
-twitpic
-flickr

Thanks for any help, lexar

@vocaro

This comment has been minimized.

Copy link

vocaro commented Oct 7, 2011

troppoli's fork is at https://github.com/troppoli/ShareKit

@spiderguy84

This comment has been minimized.

Copy link

spiderguy84 commented Oct 13, 2011

@troppoli I am sure you are aware of this but due to some changes of modal view controllers in iOS 5, the current sharekit has major issues when compiled with xcode 4.2 and base sdk of 5.0. Cancel buttons will not dismiss the current view when closing out emails, or Twitter. I was able to fix the twitter part by removing the SHKCUrrenthelper and replacing with self dismissmodalviewcontroller code, but not on the email. Have you been able to work on a good fix for this issue?

@postmechanical

This comment has been minimized.

Copy link

postmechanical commented Oct 13, 2011

See the iOS 5 documentation for the new method presentingViewController and changes to parentViewController as it is now out of NDA.

parentViewController
The parent of the current view controller. (read-only)

@Property(nonatomic, readonly) UIViewController *parentViewController
Discussion
Parent view controllers are relevant in navigation, tab bar, and modal view controller hierarchies. In each of these hierarchies, the parent is the object responsible for displaying the current view controller. If you are using a view controller as a standalone object—that is, not as part of a view controller hierarchy—the value in this property is nil.

Prior to iOS 5.0, if a view did not have a parent view controller and was being presented modally, the view controller that was presenting it would be returned. This is no longer the case. You can get the presenting view controller using the presentingViewController property.

Availability
Available in iOS 2.0 and later.
See Also
@Property modalViewController
Declared In
UIViewController.h

presentingViewController
The view controller that presented this view controller. (read-only)

@Property(nonatomic, readonly) UIViewController *presentingViewController
Discussion
The default implementation of this property walks up the view hierarchy, starting from this view controller. The first view controller it finds that received the presentViewController:animated:completion: method, or that has its definesPresentationContext property set to YES is returned as the value of the property. It keeps walking up the hierarchy until it finds a value to return or it gets to the root view controller.

Availability
Available in iOS 5.0 and later.
Declared In
UIViewController.h

@spiderguy84

This comment has been minimized.

Copy link

spiderguy84 commented Oct 15, 2011

Yes, I realize and have read this documentation. My question is about ShareKit...on iOS 5 because of the changes you wrote above, the view for logging into Twitter to authorize the app, does not disappear upon authorizing, or clicking the cancel button. Where in the ShareKit code needs to be changed in order to have that disappear?

@scompt

This comment has been minimized.

Copy link

scompt commented Oct 15, 2011

@spiderguy84 We're working on a patch for this problem over here if you're interested in switching the fork you're using.

@spiderguy84

This comment has been minimized.

Copy link

spiderguy84 commented Oct 15, 2011

I was able to take care of this problem with the help of someone in iphonedevsdk.com. One thing I am having issue with now is Facebook not sharing text. I use this code:
[CODE]

  • (IBAction)postGradesTapped:(id)sender {

    self.textual = @"Test";
    SHKItem *item = [SHKItem text:self.textual];
    SHKActionSheet *actionSheet = [SHKActionSheet actionSheetForItem:item];
    [actionSheet showInView:self.tabBarController.view];

}[/CODE]
Twitter and Email handle it fine, butFacebook just leaves dialog box empty, or will sometime give NSURLConnectionError -999 message.

@spiderguy84

This comment has been minimized.

Copy link

spiderguy84 commented Oct 17, 2011

Ok, here is what I am having troubles with right now on the fork I am using. When you share a URL, the facebook window doesn't show the link that is being shared, although it does end up getting posted. I'm concerned that the user will think something is wrong when they don't see it, and cancel it. How can I set it up to show in the preview window of the app? Here is what the user sees:
http://www.316apps.com/usersees.png

Here is what gets posted:
http://www.316apps.com/getsposted.png

@evripidis

This comment has been minimized.

Copy link

evripidis commented Nov 5, 2011

I've updated my files from the ShareKit web site with those in here.

Facebook has major issues. When i press FB share, it pops app the facebook app, and do nothing more.

@KanybekMomukeyev

This comment has been minimized.

Copy link

KanybekMomukeyev commented Nov 9, 2011

evripidis, this problem occurs, when your application ID (which you registered in facebook) is incorrect.

@sebrk

This comment has been minimized.

Copy link

sebrk commented Nov 9, 2011

I'm having difficulties following this (I'm not that into Git yet I guess). Will there be a ShareKit 2.0 in the coming days or weeks or even months?

@vocaro

This comment has been minimized.

@KanybekMomukeyev

This comment has been minimized.

Copy link

KanybekMomukeyev commented Nov 10, 2011

when i am sharing, in sharekit 2.0 LINK, everything is working ok,
i added to my project, everything is good, BUT when i try to share LINK with facebook,
nothing will happen. I've changed plist, used id that given in sharekit, nothing.... Please help

@evripidis

This comment has been minimized.

Copy link

evripidis commented Nov 13, 2011

@KanybekMomukeyev The app ID is correct cause i can see the ID info into the FB app.

Here is exactly where i stuck. I am sharing a text with Link and nothing happens

@Sjors

This comment has been minimized.

Copy link

Sjors commented Nov 29, 2011

@sebrk at the moment the development branch is the most recent:
https://github.com/ShareKit/ShareKit/tree/development

Here are the most up to date installation instructions (if I'm not mistaken):
https://github.com/ShareKit/ShareKit/wiki/Installing-sharekit

@SlavaBushtruk

This comment has been minimized.

Copy link
Author

SlavaBushtruk commented Dec 9, 2011

@sateeshkumardamera

This comment has been minimized.

Copy link

sateeshkumardamera commented Jul 20, 2012

I got the error like operation could not be completed, contents ={ "OAuthException"} contents ={ "(#100) action links must have string 'href' and 'text' attributes"}

Can any one help on this

@xhzengAIB

This comment has been minimized.

Copy link

xhzengAIB commented Sep 18, 2012

Please:

Why the sharekit added to my project is not working properly?Example: In SHKActionSheet.m files inside
id class;
for (NSString * sharerId in favoriteSharers)
{
        NSLog (@ "% @", sharerId);
class = NSClassFromString (sharerId);
if ([class canShare])
{
[as addButtonWithTitle: [class sharerTitle]];
[as.sharers addObject: sharerId];
}
}
class is nil
How do I do????

@SohaibQazi

This comment has been minimized.

Copy link

SohaibQazi commented Aug 1, 2013

Hi,
I have just downloaded ShareKit. I am trying to run ShareKit demo app.xproject file but it is showing me some errors like PocketAPI.h file not found. BufferSDK.h file not found. I don't know how to run the project of sharekit that i just downloaded. Can someone explain me how can i check it?

@aelam

This comment has been minimized.

Copy link

aelam commented Mar 17, 2015

Some vendors support SSO login. is it possible to add the feature in ?

@ranamateen

This comment has been minimized.

Copy link

ranamateen commented Apr 11, 2018

Getting this error while installing sharekit pods
screen shot 2018-04-11 at 7 38 57 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment