Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix a crash when root view controller have to be defined by developer using setRootViewController #129

Open
wants to merge 87 commits into from
@rs
rs commented

This bug was introduced by 0e3dd3e

To reproduce, just use the library in a way it can't determine the root view controller by itself and set it using advised [[SHK currentHelper] setRootViewController:...]; then use a service which require more than one modal view (i.e.: unlogged twitter in xauth mode).

and others added some commits
@ideashower initial commit dd1e629
@ideashower Revising README for clarity 812fe20
@ideashower README typo d37fe7b
Sean Murphy Modified SHKRequest to interpret a 201 HTTP status code (Created) as …
…successful
cbeff26
Sean Murphy Added Instapaper sharer 9c60e46
@ideashower Merge branch 'master' of github.com:ideashower/ShareKit 1513111
@ideashower Cleaned up SHKInstapaper, Modified SHKSharer to support services with…
… optional passwords
69bbcaa
Jamie Pinkham created tumblr sharer 5a8c40d
@ideashower reverting changes from SHKConfig made by fork fc9d54e
@ideashower removing user pbx files from example project dcb84c3
@ideashower New Configuration Options:
- Debug switch
- ModalPresentationStyle (for iPad apps)
- ModalTransitionStyle (for iPad apps)

New Features:
- Logout of all services +[SHK logoutOfAll]
- Logout of specific service +[SHK logoutOfService:serviceId]

Critical Fixes:
- Delicious token expiring after 1 hour
- Bit.ly could return non-bit.ly domains causing shortened url to be rejected

Minor Improvements:
- SHKActionSheet tried to act on indexes less than 0
- Cancelling OAuth login no longer prompts 'user cancelled' error message

Other bug fixes
6f1ca7b
@ideashower last minute cleanups before releasing 0.1.5 b7baddd
@ideashower - Fixed logout on device
- Fixed facebook logout
- Added additional comments for setting up twitter
- Added sanity check to catch pin based auth with twitter
- Version 0.1.6 - release going to website
3b18089
@ideashower fixed test case in example project 1a6b59c
@ideashower Cleanup 5a66c85
@steipete steipete full localization support for ShareKit. Added german.
You can add your own language by simply adding your lang in ShareKit.bundle.

You have to include ShareKit.bundle now in your project
38bc1f8
@steipete steipete completed german localization 2f9da86
@steipete steipete add localization for twitter a8785b8
@steipete steipete BUGFIX: filter out sharers that can't share, thus create no button bu…
…t were evaluated on clickedButtonAtIndex. This produced a black screen when no mail client was setup, mail was a favorite and the user pressed "more".
560f60e
@steipete steipete fix: add single sharer, not class 8081db8
@ideashower New:
- SHKPhotoAlbum: Save images to photo album action
- Facebook accepts text sharing

Fixes:
- SHKItem now carries over full item when sharing
- Crash when saving items offline that did not contain custom variables
- Modal popups would not go away when using pagesheet modal type on iPad
- Editing sharers now affects actionsheet choices
- Race condition in SHKShareMenu

Improvements:
- Improved display of SHKTwitterForm on iPad
- Facebook uses text variable when sharing urls to repopulate status message
- SHKMail now uses up to date template, improved handling of text when it's available in SHKItem
- Updated SHKActionSheet to not override delegate, now you can assign your own delegate

Code Refactoring:
- Renamed SHLocalizedString to use proper SHK prefix
- Updated SHKLocalizedString to work like stringWithFormat
- Removed/Combined some localization strings
3a6a746
@ideashower Version 0.2.0
-SHKTwitter: Don't attempt to shorten while offline
-SHKTwitter: Crash on @"Follow %@" format string
-SHKEmail: Added 'Sent with ...'
-SHKDelicious: Titles were double encoded
-SHK: SHKStringOrBlank function

-Updated FBConnect to version 1.3.0
692b98a
Victor Add on/off for alphabetical ordering items in ShareMenu bb42f4c
Victor Fix crash due to asking for session for AutoShare when the Sharer is …
…set to NO for AutoShare
0af9e32
Victor Username/password texfield should not have autocorrection and autocap…
…italization
f83bbca
Victor fix: UIImageJPEGRepresentation specification takes in compression rat…
…io from 0.0 to 1.0
07bab21
@steipete steipete add localization for example document 0f878ea
@steipete steipete fixed localization in ShareKit example code e505e4d
@innopage innopage SHKTwitter : added img.ly image sharing for 8fd4ecc
@adamawolf adamawolf fixing crash caused by malformed error message formatting in case of …
…oauth authentication failure
779093f
@innopage innopage Fix OAMutableURLRequest bugs with parameters b9fb96a
@innopage innopage Fix UIImageJPEGRepresentation only takes in compression ratio from 0.…
…0 to 1.0
dd09d50
@adamawolf adamawolf BUGFIX: in facebook if you login->logout->log back in, the post windo…
…w doesn't appear the second time
1e55db2
Bryan Bonczek Added session proxy support for Facebook Connect. 1b407d8
Bryan Bonczek Modified Facebook logout code to work with session proxying. f084a13
@innopage innopage Better Error handling for image upload 4ffde13
@innopage innopage Fix bug on image upload url checking 83d0c56
@ideashower - New: Option to disable 'shared with …' email signature
- New: Added 'logout' button example to project

- Improved: Moved translations into file structure that is easier to view in github

- Fixed: Translations not being applied
- Fixed: C++ compile error because of 'new' in SHKSwizzle
- Fixed: Twitter message dialog appearing blank
- Fixed: Twitter failed to login with special characters (%&,etc) in password
- Fixed: OAuth logout now flushes cookies from domain too
- Fixed: Twitter dialog does not display 'ALREADY_A_BITLY_LINK' from bit.ly response
- Fixed: SHKMail now listens to SHKModalTransitionStyle
- Fixed: SHKMail signature not localized
- Fixed: Problems in devices without email configured
- Fixed: Issue where SHKActionSheet could respond to the incorrect choice
- Fixed: Removed auto-correction form login form fields
cf3bdfb
@ideashower cleanup 095b2c9
@ideashower - Fixed: Offline sharing of images and files a41fde8
@ideashower Missed SHKSwizzle header update bc26043
@ideashower Reverted objc-class import line 7f35b4e
Atsushi Nagase in progress 1c13c62
@ngs ngs in progress b136deb
@ngs ngs SHKEvernote 0d959bb
@ngs ngs Clip shorten URLs to Evernote / Copy/ Mail 0aeea56
@ngs ngs Define should attach shorten URLs to Emails or Pasteboard with constants 13c16e0
@ngs ngs Added document 5860033
@ngs ngs dded document 0ab15b4
@ngs ngs Merge branch 'master' of github.com:ngs/ShareKit 4b1563c
@ngs ngs Merge branch 'master' of github.com:ngs/ShareKit c2fcd98
@ngs ngs Added document 5b288a5
@ngs ngs Merge branch 'master' of github.com:ngs/ShareKit 4adb065
@ngs ngs Forgot to set note property. 71208ad
@ngs ngs forgot using NSAutoreleasePool in subthread method 9720e2f
@esti esti Added translation to Basque language 40130d6
@wbroek wbroek Added dutch translation 34f7f3b
@ideashower Merge branch 'master' of https://github.com/ngs/ShareKit into ngs-master 0adb417
Benjamin Jackson Fixed memory leaks in OAuth helper classes. facf8eb
Benjamin Jackson Fixed crash when clicking "More" after the original rootViewControlle…
…r had been released (it's never retained by the library).
0e3dd3e
@luosheng luosheng Made some strings localizable. b04d238
@luosheng luosheng Added localization strings for Simplified Chinese. f8fab1f
@ideashower Merge branch 'master' of github.com:ideashower/ShareKit 6ea78b0
@ideashower proj 81ffd1f
@quanganhdo quanganhdo Add Vietnamese localization e447d47
AxFree Added translation to Korean language. 7f34144
AxFree Added some strings for localization. 35aca82
@maarek maarek Added text message capabilities for SMS messages.
Share Text Message through Text button to launch
Messages on iOS4 only.
e4c0314
@jamiebriant jamiebriant Fixed warnings so we can compile with warnings as
errors.
952aed9
@jamiebriant jamiebriant Updated gitignore bfc9c9a
@jamiebriant jamiebriant Fixed warning 1bc8b48
@triplef triplef Fixed unreleased views. b0b8a5d
@triplef triplef Fixed empty view when no mail account is registered. fff40a5
@treelinelabs treelinelabs Atomic synthesized setters can't be pairer with implemented getters 7bfd9f0
@treelinelabs treelinelabs Use the instance, not the class, as the delegate ca11f25
@ideashower - Added French Localization
- Cleaned up Evernote Sharer
- Added error handling to Evernote Sharer
- Fixed bug where Mail would not dimiss after opening address book
- Fixed cancelation notification not sending for Twitter
- Updated obj-class import
- Fixed logic error missing attachments when body is set
- Fixed mail showing empty view when mail is not configured
- Cleaned up text message sharer
7bc337d
@ideashower Merge branch 'master' of github.com:ideashower/ShareKit
Conflicts:
	Classes/ShareKit/Core/Base Sharer Classes/SHKSharer.m
	Classes/ShareKit/Core/SHK.m
	Classes/ShareKit/Sharers/Actions/Text Message/SHKTextMessage.m
	Classes/ShareKit/UI/SHKActionSheet.m
	ShareKit.xcodeproj/project.pbxproj
6a005c3
@ideashower Fixing merge issues 75dce48
@ideashower Removing files that were moved e3642d9
@rs rs Fix a crash when root view controller have to be defined by developer…
… using setRootViewController
2121cbc
@rs rs Add support for 'caption' and 'description' fields in Facebook URL sh…
…aring using SHKItem custom values
03f16da
@rs rs Add auto-detection of Dailymotion video links when sharing on Faceboo…
…k and generate an embed player attachement
bfaa9f1
@rs rs Add dailymotion video link detection to tumblr service and add embed …
…player to the post with the ability to append some text bellow it
bec7243
@rs rs Fix static analyser warnings 3f016b4
@rs rs Encode capture and description for Facebook service 1c85119
@rs rs Fix some more static analyzer warnings 1d7516d
@rs rs Fix twice released object 8a7f1da
@troppoli

FYI, this should be self.currentView = nil because this is a retained property. Not using self. will cause this to be leaked.

@jalmatari

thank you very much.. that's helpful to me. and return the hope to me;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 6, 2010
  1. initial commit

    authored
Commits on Jul 8, 2010
  1. README typo

    authored
Commits on Jul 9, 2010
  1. Modified SHKRequest to interpret a 201 HTTP status code (Created) as …

    Sean Murphy authored committed
    …successful
  2. Added Instapaper sharer

    Sean Murphy authored committed
Commits on Jul 12, 2010
  1. created tumblr sharer

    Jamie Pinkham authored committed
  2. New Configuration Options:

    authored
    - Debug switch
    - ModalPresentationStyle (for iPad apps)
    - ModalTransitionStyle (for iPad apps)
    
    New Features:
    - Logout of all services +[SHK logoutOfAll]
    - Logout of specific service +[SHK logoutOfService:serviceId]
    
    Critical Fixes:
    - Delicious token expiring after 1 hour
    - Bit.ly could return non-bit.ly domains causing shortened url to be rejected
    
    Minor Improvements:
    - SHKActionSheet tried to act on indexes less than 0
    - Cancelling OAuth login no longer prompts 'user cancelled' error message
    
    Other bug fixes
Commits on Jul 13, 2010
  1. - Fixed logout on device

    authored
    - Fixed facebook logout
    - Added additional comments for setting up twitter
    - Added sanity check to catch pin based auth with twitter
    - Version 0.1.6 - release going to website
  2. Cleanup

    authored
Commits on Jul 19, 2010
  1. @steipete

    full localization support for ShareKit. Added german.

    steipete authored
    You can add your own language by simply adding your lang in ShareKit.bundle.
    
    You have to include ShareKit.bundle now in your project
  2. @steipete

    completed german localization

    steipete authored
  3. @steipete

    add localization for twitter

    steipete authored
Commits on Jul 26, 2010
  1. @steipete

    BUGFIX: filter out sharers that can't share, thus create no button bu…

    steipete authored
    …t were evaluated on clickedButtonAtIndex. This produced a black screen when no mail client was setup, mail was a favorite and the user pressed "more".
  2. @steipete
Commits on Jul 27, 2010
  1. New:

    authored
    - SHKPhotoAlbum: Save images to photo album action
    - Facebook accepts text sharing
    
    Fixes:
    - SHKItem now carries over full item when sharing
    - Crash when saving items offline that did not contain custom variables
    - Modal popups would not go away when using pagesheet modal type on iPad
    - Editing sharers now affects actionsheet choices
    - Race condition in SHKShareMenu
    
    Improvements:
    - Improved display of SHKTwitterForm on iPad
    - Facebook uses text variable when sharing urls to repopulate status message
    - SHKMail now uses up to date template, improved handling of text when it's available in SHKItem
    - Updated SHKActionSheet to not override delegate, now you can assign your own delegate
    
    Code Refactoring:
    - Renamed SHLocalizedString to use proper SHK prefix
    - Updated SHKLocalizedString to work like stringWithFormat
    - Removed/Combined some localization strings
  2. Version 0.2.0

    authored
    -SHKTwitter: Don't attempt to shorten while offline
    -SHKTwitter: Crash on @"Follow %@" format string
    -SHKEmail: Added 'Sent with ...'
    -SHKDelicious: Titles were double encoded
    -SHK: SHKStringOrBlank function
    
    -Updated FBConnect to version 1.3.0
Commits on Aug 25, 2010
  1. Add on/off for alphabetical ordering items in ShareMenu

    Victor authored committed
  2. Fix crash due to asking for session for AutoShare when the Sharer is …

    Victor authored committed
    …set to NO for AutoShare
  3. Username/password texfield should not have autocorrection and autocap…

    Victor authored committed
    …italization
  4. fix: UIImageJPEGRepresentation specification takes in compression rat…

    Victor authored committed
    …io from 0.0 to 1.0
  5. @steipete

    add localization for example document

    steipete authored committed
  6. @steipete

    fixed localization in ShareKit example code

    steipete authored committed
  7. @innopage

    SHKTwitter : added img.ly image sharing for

    innopage authored committed
  8. @adamawolf

    fixing crash caused by malformed error message formatting in case of …

    adamawolf authored committed
    …oauth authentication failure
  9. @innopage

    Fix OAMutableURLRequest bugs with parameters

    innopage authored committed
  10. @innopage

    Fix UIImageJPEGRepresentation only takes in compression ratio from 0.…

    innopage authored committed
    …0 to 1.0
  11. @adamawolf

    BUGFIX: in facebook if you login->logout->log back in, the post windo…

    adamawolf authored committed
    …w doesn't appear the second time
  12. Added session proxy support for Facebook Connect.

    Bryan Bonczek authored committed
  13. Modified Facebook logout code to work with session proxying.

    Bryan Bonczek authored committed
  14. @innopage

    Better Error handling for image upload

    innopage authored committed
  15. @innopage

    Fix bug on image upload url checking

    innopage authored committed
Commits on Aug 26, 2010
  1. - New: Option to disable 'shared with …' email signature

    authored
    - New: Added 'logout' button example to project
    
    - Improved: Moved translations into file structure that is easier to view in github
    
    - Fixed: Translations not being applied
    - Fixed: C++ compile error because of 'new' in SHKSwizzle
    - Fixed: Twitter message dialog appearing blank
    - Fixed: Twitter failed to login with special characters (%&,etc) in password
    - Fixed: OAuth logout now flushes cookies from domain too
    - Fixed: Twitter dialog does not display 'ALREADY_A_BITLY_LINK' from bit.ly response
    - Fixed: SHKMail now listens to SHKModalTransitionStyle
    - Fixed: SHKMail signature not localized
    - Fixed: Problems in devices without email configured
    - Fixed: Issue where SHKActionSheet could respond to the incorrect choice
    - Fixed: Removed auto-correction form login form fields
  2. cleanup

    authored
Commits on Aug 27, 2010
Commits on Aug 30, 2010
Commits on Oct 6, 2010
  1. in progress

    Atsushi Nagase authored
  2. @ngs

    in progress

    ngs authored
  3. @ngs

    SHKEvernote

    ngs authored
Commits on Oct 7, 2010
  1. @ngs
Commits on Oct 12, 2010
  1. @ngs
  2. @ngs

    Added document

    ngs authored
  3. @ngs

    dded document

    ngs authored
  4. @ngs
  5. @ngs
  6. @ngs

    Added document

    ngs authored
  7. @ngs
  8. @ngs

    Forgot to set note property.

    ngs authored
Commits on Oct 26, 2010
  1. @ngs
Commits on Nov 15, 2010
  1. @esti

    Added translation to Basque language

    esti authored committed
  2. @wbroek

    Added dutch translation

    wbroek authored committed
  3. Fixed memory leaks in OAuth helper classes.

    Benjamin Jackson authored committed
  4. Fixed crash when clicking "More" after the original rootViewControlle…

    Benjamin Jackson authored committed
    …r had been released (it's never retained by the library).
  5. @luosheng

    Made some strings localizable.

    luosheng authored committed
  6. @luosheng

    Added localization strings for Simplified Chinese.

    luosheng authored committed
  7. proj

    authored
  8. @quanganhdo

    Add Vietnamese localization

    quanganhdo authored committed
  9. Added translation to Korean language.

    AxFree authored committed
  10. Added some strings for localization.

    AxFree authored committed
  11. @maarek

    Added text message capabilities for SMS messages.

    maarek authored committed
    Share Text Message through Text button to launch
    Messages on iOS4 only.
  12. @jamiebriant

    Fixed warnings so we can compile with warnings as

    jamiebriant authored committed
    errors.
  13. @jamiebriant

    Updated gitignore

    jamiebriant authored committed
  14. @jamiebriant

    Fixed warning

    jamiebriant authored committed
  15. @triplef

    Fixed unreleased views.

    triplef authored committed
  16. @triplef

    Fixed empty view when no mail account is registered.

    triplef authored committed
  17. @treelinelabs
  18. @treelinelabs

    Use the instance, not the class, as the delegate

    treelinelabs authored committed
  19. - Added French Localization

    authored
    - Cleaned up Evernote Sharer
    - Added error handling to Evernote Sharer
    - Fixed bug where Mail would not dimiss after opening address book
    - Fixed cancelation notification not sending for Twitter
    - Updated obj-class import
    - Fixed logic error missing attachments when body is set
    - Fixed mail showing empty view when mail is not configured
    - Cleaned up text message sharer
  20. Merge branch 'master' of github.com:ideashower/ShareKit

    authored
    Conflicts:
    	Classes/ShareKit/Core/Base Sharer Classes/SHKSharer.m
    	Classes/ShareKit/Core/SHK.m
    	Classes/ShareKit/Sharers/Actions/Text Message/SHKTextMessage.m
    	Classes/ShareKit/UI/SHKActionSheet.m
    	ShareKit.xcodeproj/project.pbxproj
  21. Fixing merge issues

    authored
Commits on Nov 22, 2010
  1. @rs

    Fix a crash when root view controller have to be defined by developer…

    rs authored
    … using setRootViewController
  2. @rs

    Add support for 'caption' and 'description' fields in Facebook URL sh…

    rs authored
    …aring using SHKItem custom values
  3. @rs

    Add auto-detection of Dailymotion video links when sharing on Faceboo…

    rs authored
    …k and generate an embed player attachement
  4. @rs

    Add dailymotion video link detection to tumblr service and add embed …

    rs authored
    …player to the post with the ability to append some text bellow it
  5. @rs

    Fix static analyser warnings

    rs authored
  6. @rs
  7. @rs
  8. @rs

    Fix twice released object

    rs authored
Something went wrong with that request. Please try again.