Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Facebook additions #96

Open
wants to merge 87 commits into from

16 participants

Olivier Poitrey jalmatari troppoli Nate Weiner Peter Steinberger Victor Lam Adam Wolf Atsushi NAGASE esti Wouter van den Broek Sheng Luo Anh Quang Do Jeremy Jamie Briant Frederik Joshua Bleecher Snyder
Olivier Poitrey
rs commented

Hi,

I've added two features to facebook:

  • It become possible to add a caption and a description by providing those fields as custom value to SHKItem.
  • Dailymotion video links are automatically detected when shared on Facebook in order to generate an embed player associated to the link.

Best,

and others added some commits
Nate Weiner initial commit dd1e629
Nate Weiner Revising README for clarity 812fe20
Nate Weiner README typo d37fe7b
Sean Murphy Modified SHKRequest to interpret a 201 HTTP status code (Created) as …
…successful
cbeff26
Sean Murphy Added Instapaper sharer 9c60e46
Nate Weiner Merge branch 'master' of github.com:ideashower/ShareKit 1513111
Nate Weiner Cleaned up SHKInstapaper, Modified SHKSharer to support services with…
… optional passwords
69bbcaa
Jamie Pinkham created tumblr sharer 5a8c40d
Nate Weiner reverting changes from SHKConfig made by fork fc9d54e
Nate Weiner removing user pbx files from example project dcb84c3
Nate Weiner New Configuration Options:
- Debug switch
- ModalPresentationStyle (for iPad apps)
- ModalTransitionStyle (for iPad apps)

New Features:
- Logout of all services +[SHK logoutOfAll]
- Logout of specific service +[SHK logoutOfService:serviceId]

Critical Fixes:
- Delicious token expiring after 1 hour
- Bit.ly could return non-bit.ly domains causing shortened url to be rejected

Minor Improvements:
- SHKActionSheet tried to act on indexes less than 0
- Cancelling OAuth login no longer prompts 'user cancelled' error message

Other bug fixes
6f1ca7b
Nate Weiner last minute cleanups before releasing 0.1.5 b7baddd
Nate Weiner - Fixed logout on device
- Fixed facebook logout
- Added additional comments for setting up twitter
- Added sanity check to catch pin based auth with twitter
- Version 0.1.6 - release going to website
3b18089
Nate Weiner fixed test case in example project 1a6b59c
Nate Weiner Cleanup 5a66c85
Peter Steinberger steipete full localization support for ShareKit. Added german.
You can add your own language by simply adding your lang in ShareKit.bundle.

You have to include ShareKit.bundle now in your project
38bc1f8
Peter Steinberger steipete completed german localization 2f9da86
Peter Steinberger steipete add localization for twitter a8785b8
Peter Steinberger steipete BUGFIX: filter out sharers that can't share, thus create no button bu…
…t were evaluated on clickedButtonAtIndex. This produced a black screen when no mail client was setup, mail was a favorite and the user pressed "more".
560f60e
Peter Steinberger steipete fix: add single sharer, not class 8081db8
Nate Weiner New:
- SHKPhotoAlbum: Save images to photo album action
- Facebook accepts text sharing

Fixes:
- SHKItem now carries over full item when sharing
- Crash when saving items offline that did not contain custom variables
- Modal popups would not go away when using pagesheet modal type on iPad
- Editing sharers now affects actionsheet choices
- Race condition in SHKShareMenu

Improvements:
- Improved display of SHKTwitterForm on iPad
- Facebook uses text variable when sharing urls to repopulate status message
- SHKMail now uses up to date template, improved handling of text when it's available in SHKItem
- Updated SHKActionSheet to not override delegate, now you can assign your own delegate

Code Refactoring:
- Renamed SHLocalizedString to use proper SHK prefix
- Updated SHKLocalizedString to work like stringWithFormat
- Removed/Combined some localization strings
3a6a746
Nate Weiner Version 0.2.0
-SHKTwitter: Don't attempt to shorten while offline
-SHKTwitter: Crash on @"Follow %@" format string
-SHKEmail: Added 'Sent with ...'
-SHKDelicious: Titles were double encoded
-SHK: SHKStringOrBlank function

-Updated FBConnect to version 1.3.0
692b98a
Victor Add on/off for alphabetical ordering items in ShareMenu bb42f4c
Victor Fix crash due to asking for session for AutoShare when the Sharer is …
…set to NO for AutoShare
0af9e32
Victor Username/password texfield should not have autocorrection and autocap…
…italization
f83bbca
Victor fix: UIImageJPEGRepresentation specification takes in compression rat…
…io from 0.0 to 1.0
07bab21
Peter Steinberger steipete add localization for example document 0f878ea
Peter Steinberger steipete fixed localization in ShareKit example code e505e4d
Victor Lam innopage SHKTwitter : added img.ly image sharing for 8fd4ecc
Adam Wolf adamawolf fixing crash caused by malformed error message formatting in case of …
…oauth authentication failure
779093f
Victor Lam innopage Fix OAMutableURLRequest bugs with parameters b9fb96a
Victor Lam innopage Fix UIImageJPEGRepresentation only takes in compression ratio from 0.…
…0 to 1.0
dd09d50
Adam Wolf adamawolf BUGFIX: in facebook if you login->logout->log back in, the post windo…
…w doesn't appear the second time
1e55db2
Bryan Bonczek Added session proxy support for Facebook Connect. 1b407d8
Bryan Bonczek Modified Facebook logout code to work with session proxying. f084a13
Victor Lam innopage Better Error handling for image upload 4ffde13
Victor Lam innopage Fix bug on image upload url checking 83d0c56
Nate Weiner - New: Option to disable 'shared with …' email signature
- New: Added 'logout' button example to project

- Improved: Moved translations into file structure that is easier to view in github

- Fixed: Translations not being applied
- Fixed: C++ compile error because of 'new' in SHKSwizzle
- Fixed: Twitter message dialog appearing blank
- Fixed: Twitter failed to login with special characters (%&,etc) in password
- Fixed: OAuth logout now flushes cookies from domain too
- Fixed: Twitter dialog does not display 'ALREADY_A_BITLY_LINK' from bit.ly response
- Fixed: SHKMail now listens to SHKModalTransitionStyle
- Fixed: SHKMail signature not localized
- Fixed: Problems in devices without email configured
- Fixed: Issue where SHKActionSheet could respond to the incorrect choice
- Fixed: Removed auto-correction form login form fields
cf3bdfb
Nate Weiner cleanup 095b2c9
Nate Weiner - Fixed: Offline sharing of images and files a41fde8
Nate Weiner Missed SHKSwizzle header update bc26043
Nate Weiner Reverted objc-class import line 7f35b4e
Atsushi Nagase in progress 1c13c62
Atsushi NAGASE ngs in progress b136deb
Atsushi NAGASE ngs SHKEvernote 0d959bb
Atsushi NAGASE ngs Clip shorten URLs to Evernote / Copy/ Mail 0aeea56
Atsushi NAGASE ngs Define should attach shorten URLs to Emails or Pasteboard with constants 13c16e0
Atsushi NAGASE ngs Added document 5860033
Atsushi NAGASE ngs dded document 0ab15b4
Atsushi NAGASE ngs Merge branch 'master' of github.com:ngs/ShareKit 4b1563c
Atsushi NAGASE ngs Merge branch 'master' of github.com:ngs/ShareKit c2fcd98
Atsushi NAGASE ngs Added document 5b288a5
Atsushi NAGASE ngs Merge branch 'master' of github.com:ngs/ShareKit 4adb065
Atsushi NAGASE ngs Forgot to set note property. 71208ad
Atsushi NAGASE ngs forgot using NSAutoreleasePool in subthread method 9720e2f
esti esti Added translation to Basque language 40130d6
Wouter van den Broek wbroek Added dutch translation 34f7f3b
Nate Weiner Merge branch 'master' of https://github.com/ngs/ShareKit into ngs-master 0adb417
Benjamin Jackson Fixed memory leaks in OAuth helper classes. facf8eb
Benjamin Jackson Fixed crash when clicking "More" after the original rootViewControlle…
…r had been released (it's never retained by the library).
0e3dd3e
Sheng Luo luosheng Made some strings localizable. b04d238
Sheng Luo luosheng Added localization strings for Simplified Chinese. f8fab1f
Nate Weiner Merge branch 'master' of github.com:ideashower/ShareKit 6ea78b0
Nate Weiner proj 81ffd1f
Anh Quang Do quanganhdo Add Vietnamese localization e447d47
AxFree Added translation to Korean language. 7f34144
AxFree Added some strings for localization. 35aca82
Jeremy maarek Added text message capabilities for SMS messages.
Share Text Message through Text button to launch
Messages on iOS4 only.
e4c0314
Jamie Briant jamiebriant Fixed warnings so we can compile with warnings as
errors.
952aed9
Jamie Briant jamiebriant Updated gitignore bfc9c9a
Jamie Briant jamiebriant Fixed warning 1bc8b48
Frederik triplef Fixed unreleased views. b0b8a5d
Frederik triplef Fixed empty view when no mail account is registered. fff40a5
Joshua Bleecher Snyder treelinelabs Atomic synthesized setters can't be pairer with implemented getters 7bfd9f0
Joshua Bleecher Snyder treelinelabs Use the instance, not the class, as the delegate ca11f25
Nate Weiner - Added French Localization
- Cleaned up Evernote Sharer
- Added error handling to Evernote Sharer
- Fixed bug where Mail would not dimiss after opening address book
- Fixed cancelation notification not sending for Twitter
- Updated obj-class import
- Fixed logic error missing attachments when body is set
- Fixed mail showing empty view when mail is not configured
- Cleaned up text message sharer
7bc337d
Nate Weiner Merge branch 'master' of github.com:ideashower/ShareKit
Conflicts:
	Classes/ShareKit/Core/Base Sharer Classes/SHKSharer.m
	Classes/ShareKit/Core/SHK.m
	Classes/ShareKit/Sharers/Actions/Text Message/SHKTextMessage.m
	Classes/ShareKit/UI/SHKActionSheet.m
	ShareKit.xcodeproj/project.pbxproj
6a005c3
Nate Weiner Fixing merge issues 75dce48
Nate Weiner Removing files that were moved e3642d9
Olivier Poitrey rs Fix a crash when root view controller have to be defined by developer…
… using setRootViewController
2121cbc
Olivier Poitrey rs Add support for 'caption' and 'description' fields in Facebook URL sh…
…aring using SHKItem custom values
03f16da
Olivier Poitrey rs Add auto-detection of Dailymotion video links when sharing on Faceboo…
…k and generate an embed player attachement
bfaa9f1
Olivier Poitrey rs Add dailymotion video link detection to tumblr service and add embed …
…player to the post with the ability to append some text bellow it
bec7243
Olivier Poitrey rs Fix static analyser warnings 3f016b4
Olivier Poitrey rs Encode capture and description for Facebook service 1c85119
Olivier Poitrey rs Fix some more static analyzer warnings 1d7516d
Olivier Poitrey rs Fix twice released object 8a7f1da
troppoli

FYI, this should be self.currentView = nil because this is a retained property. Not using self. will cause this to be leaked.

jalmatari

thank you very much.. that's helpful to me. and return the hope to me;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 6, 2010
  1. initial commit

    authored
Commits on Jul 8, 2010
  1. README typo

    authored
Commits on Jul 9, 2010
  1. Modified SHKRequest to interpret a 201 HTTP status code (Created) as …

    Sean Murphy authored committed
    …successful
  2. Added Instapaper sharer

    Sean Murphy authored committed
Commits on Jul 12, 2010
  1. created tumblr sharer

    Jamie Pinkham authored committed
  2. New Configuration Options:

    authored
    - Debug switch
    - ModalPresentationStyle (for iPad apps)
    - ModalTransitionStyle (for iPad apps)
    
    New Features:
    - Logout of all services +[SHK logoutOfAll]
    - Logout of specific service +[SHK logoutOfService:serviceId]
    
    Critical Fixes:
    - Delicious token expiring after 1 hour
    - Bit.ly could return non-bit.ly domains causing shortened url to be rejected
    
    Minor Improvements:
    - SHKActionSheet tried to act on indexes less than 0
    - Cancelling OAuth login no longer prompts 'user cancelled' error message
    
    Other bug fixes
Commits on Jul 13, 2010
  1. - Fixed logout on device

    authored
    - Fixed facebook logout
    - Added additional comments for setting up twitter
    - Added sanity check to catch pin based auth with twitter
    - Version 0.1.6 - release going to website
  2. Cleanup

    authored
Commits on Jul 19, 2010
  1. Peter Steinberger

    full localization support for ShareKit. Added german.

    steipete authored
    You can add your own language by simply adding your lang in ShareKit.bundle.
    
    You have to include ShareKit.bundle now in your project
  2. Peter Steinberger

    completed german localization

    steipete authored
  3. Peter Steinberger

    add localization for twitter

    steipete authored
Commits on Jul 26, 2010
  1. Peter Steinberger

    BUGFIX: filter out sharers that can't share, thus create no button bu…

    steipete authored
    …t were evaluated on clickedButtonAtIndex. This produced a black screen when no mail client was setup, mail was a favorite and the user pressed "more".
  2. Peter Steinberger
Commits on Jul 27, 2010
  1. New:

    authored
    - SHKPhotoAlbum: Save images to photo album action
    - Facebook accepts text sharing
    
    Fixes:
    - SHKItem now carries over full item when sharing
    - Crash when saving items offline that did not contain custom variables
    - Modal popups would not go away when using pagesheet modal type on iPad
    - Editing sharers now affects actionsheet choices
    - Race condition in SHKShareMenu
    
    Improvements:
    - Improved display of SHKTwitterForm on iPad
    - Facebook uses text variable when sharing urls to repopulate status message
    - SHKMail now uses up to date template, improved handling of text when it's available in SHKItem
    - Updated SHKActionSheet to not override delegate, now you can assign your own delegate
    
    Code Refactoring:
    - Renamed SHLocalizedString to use proper SHK prefix
    - Updated SHKLocalizedString to work like stringWithFormat
    - Removed/Combined some localization strings
  2. Version 0.2.0

    authored
    -SHKTwitter: Don't attempt to shorten while offline
    -SHKTwitter: Crash on @"Follow %@" format string
    -SHKEmail: Added 'Sent with ...'
    -SHKDelicious: Titles were double encoded
    -SHK: SHKStringOrBlank function
    
    -Updated FBConnect to version 1.3.0
Commits on Aug 25, 2010
  1. Add on/off for alphabetical ordering items in ShareMenu

    Victor authored committed
  2. Fix crash due to asking for session for AutoShare when the Sharer is …

    Victor authored committed
    …set to NO for AutoShare
  3. Username/password texfield should not have autocorrection and autocap…

    Victor authored committed
    …italization
  4. fix: UIImageJPEGRepresentation specification takes in compression rat…

    Victor authored committed
    …io from 0.0 to 1.0
  5. Peter Steinberger

    add localization for example document

    steipete authored committed
  6. Peter Steinberger

    fixed localization in ShareKit example code

    steipete authored committed
  7. Victor Lam

    SHKTwitter : added img.ly image sharing for

    innopage authored committed
  8. Adam Wolf

    fixing crash caused by malformed error message formatting in case of …

    adamawolf authored committed
    …oauth authentication failure
  9. Victor Lam

    Fix OAMutableURLRequest bugs with parameters

    innopage authored committed
  10. Victor Lam

    Fix UIImageJPEGRepresentation only takes in compression ratio from 0.…

    innopage authored committed
    …0 to 1.0
  11. Adam Wolf

    BUGFIX: in facebook if you login->logout->log back in, the post windo…

    adamawolf authored committed
    …w doesn't appear the second time
  12. Added session proxy support for Facebook Connect.

    Bryan Bonczek authored committed
  13. Modified Facebook logout code to work with session proxying.

    Bryan Bonczek authored committed
  14. Victor Lam

    Better Error handling for image upload

    innopage authored committed
  15. Victor Lam

    Fix bug on image upload url checking

    innopage authored committed
Commits on Aug 26, 2010
  1. - New: Option to disable 'shared with …' email signature

    authored
    - New: Added 'logout' button example to project
    
    - Improved: Moved translations into file structure that is easier to view in github
    
    - Fixed: Translations not being applied
    - Fixed: C++ compile error because of 'new' in SHKSwizzle
    - Fixed: Twitter message dialog appearing blank
    - Fixed: Twitter failed to login with special characters (%&,etc) in password
    - Fixed: OAuth logout now flushes cookies from domain too
    - Fixed: Twitter dialog does not display 'ALREADY_A_BITLY_LINK' from bit.ly response
    - Fixed: SHKMail now listens to SHKModalTransitionStyle
    - Fixed: SHKMail signature not localized
    - Fixed: Problems in devices without email configured
    - Fixed: Issue where SHKActionSheet could respond to the incorrect choice
    - Fixed: Removed auto-correction form login form fields
  2. cleanup

    authored
Commits on Aug 27, 2010
Commits on Aug 30, 2010
Commits on Oct 6, 2010
  1. in progress

    Atsushi Nagase authored
  2. Atsushi NAGASE

    in progress

    ngs authored
  3. Atsushi NAGASE

    SHKEvernote

    ngs authored
Commits on Oct 7, 2010
  1. Atsushi NAGASE
Commits on Oct 12, 2010
  1. Atsushi NAGASE
  2. Atsushi NAGASE

    Added document

    ngs authored
  3. Atsushi NAGASE

    dded document

    ngs authored
  4. Atsushi NAGASE
  5. Atsushi NAGASE
  6. Atsushi NAGASE

    Added document

    ngs authored
  7. Atsushi NAGASE
  8. Atsushi NAGASE

    Forgot to set note property.

    ngs authored
Commits on Oct 26, 2010
  1. Atsushi NAGASE
Commits on Nov 15, 2010
  1. esti

    Added translation to Basque language

    esti authored committed
  2. Wouter van den Broek

    Added dutch translation

    wbroek authored committed
  3. Fixed memory leaks in OAuth helper classes.

    Benjamin Jackson authored committed
  4. Fixed crash when clicking "More" after the original rootViewControlle…

    Benjamin Jackson authored committed
    …r had been released (it's never retained by the library).
  5. Sheng Luo

    Made some strings localizable.

    luosheng authored committed
  6. Sheng Luo

    Added localization strings for Simplified Chinese.

    luosheng authored committed
  7. proj

    authored
  8. Anh Quang Do

    Add Vietnamese localization

    quanganhdo authored committed
  9. Added translation to Korean language.

    AxFree authored committed
  10. Added some strings for localization.

    AxFree authored committed
  11. Jeremy

    Added text message capabilities for SMS messages.

    maarek authored committed
    Share Text Message through Text button to launch
    Messages on iOS4 only.
  12. Jamie Briant

    Fixed warnings so we can compile with warnings as

    jamiebriant authored committed
    errors.
  13. Jamie Briant

    Updated gitignore

    jamiebriant authored committed
  14. Jamie Briant

    Fixed warning

    jamiebriant authored committed
  15. Frederik

    Fixed unreleased views.

    triplef authored committed
  16. Frederik

    Fixed empty view when no mail account is registered.

    triplef authored committed
  17. Joshua Bleecher Snyder
  18. Joshua Bleecher Snyder

    Use the instance, not the class, as the delegate

    treelinelabs authored committed
  19. - Added French Localization

    authored
    - Cleaned up Evernote Sharer
    - Added error handling to Evernote Sharer
    - Fixed bug where Mail would not dimiss after opening address book
    - Fixed cancelation notification not sending for Twitter
    - Updated obj-class import
    - Fixed logic error missing attachments when body is set
    - Fixed mail showing empty view when mail is not configured
    - Cleaned up text message sharer
  20. Merge branch 'master' of github.com:ideashower/ShareKit

    authored
    Conflicts:
    	Classes/ShareKit/Core/Base Sharer Classes/SHKSharer.m
    	Classes/ShareKit/Core/SHK.m
    	Classes/ShareKit/Sharers/Actions/Text Message/SHKTextMessage.m
    	Classes/ShareKit/UI/SHKActionSheet.m
    	ShareKit.xcodeproj/project.pbxproj
  21. Fixing merge issues

    authored
Commits on Nov 22, 2010
  1. Olivier Poitrey

    Fix a crash when root view controller have to be defined by developer…

    rs authored
    … using setRootViewController
  2. Olivier Poitrey

    Add support for 'caption' and 'description' fields in Facebook URL sh…

    rs authored
    …aring using SHKItem custom values
  3. Olivier Poitrey

    Add auto-detection of Dailymotion video links when sharing on Faceboo…

    rs authored
    …k and generate an embed player attachement
  4. Olivier Poitrey

    Add dailymotion video link detection to tumblr service and add embed …

    rs authored
    …player to the post with the ability to append some text bellow it
  5. Olivier Poitrey

    Fix static analyser warnings

    rs authored
  6. Olivier Poitrey
  7. Olivier Poitrey
  8. Olivier Poitrey

    Fix twice released object

    rs authored
Something went wrong with that request. Please try again.