From 2f4e7f36d00c3e5f7e7ef93af1b758551c869f5e Mon Sep 17 00:00:00 2001 From: shuoer86 <129674997+shuoer86@users.noreply.github.com> Date: Wed, 17 Jan 2024 23:48:40 +0800 Subject: [PATCH 1/5] fix typos --- .../intermediate_representation/create_component_bucket.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compiler/src/intermediate_representation/create_component_bucket.rs b/compiler/src/intermediate_representation/create_component_bucket.rs index 5205353d9..615c2b5a6 100644 --- a/compiler/src/intermediate_representation/create_component_bucket.rs +++ b/compiler/src/intermediate_representation/create_component_bucket.rs @@ -232,7 +232,7 @@ impl WriteC for CreateCmpBucket { } } // generate array with the positions that are actually created if there are empty components - // if not only traverse the defined positions, but i gets the value of the indexed accesed position + // if not only traverse the defined positions, but i gets the value of the indexed accessed position else{ instructions.push(format!("uint aux_positions [{}]= {};", self.defined_positions.len(), set_list(self.defined_positions.iter().map(|(x, _y)| *x).collect()))); instructions.push(format!("for (uint i_aux = 0; i_aux < {}; i_aux++) {{", self.defined_positions.len())); @@ -302,4 +302,4 @@ impl WriteC for CreateCmpBucket { instructions.push("}".to_string()); (instructions, "".to_string()) } -} \ No newline at end of file +} From c5ccfa0b835e1ad1fa15ab6d64a8e2708509dca9 Mon Sep 17 00:00:00 2001 From: shuoer86 <129674997+shuoer86@users.noreply.github.com> Date: Wed, 17 Jan 2024 23:48:48 +0800 Subject: [PATCH 2/5] fix typos --- constraint_generation/src/execute.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/constraint_generation/src/execute.rs b/constraint_generation/src/execute.rs index a4d085fff..ebb712296 100644 --- a/constraint_generation/src/execute.rs +++ b/constraint_generation/src/execute.rs @@ -820,7 +820,7 @@ fn execute_signal_declaration( } /* - In case the assigment could be a constraint generator the returned value is the constraint + In case the assignment could be a constraint generator the returned value is the constraint that will be created */ struct Constrained { @@ -2488,4 +2488,4 @@ fn add_report_to_runtime( } report.add_note(trace); runtime_errors.push(report); -} \ No newline at end of file +} From b4e8e2122fa2682334387a3d489477bac41f9723 Mon Sep 17 00:00:00 2001 From: shuoer86 <129674997+shuoer86@users.noreply.github.com> Date: Wed, 17 Jan 2024 23:48:54 +0800 Subject: [PATCH 3/5] fix typos --- mkdocs/docs/circom-language/formats/simplification-json.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkdocs/docs/circom-language/formats/simplification-json.md b/mkdocs/docs/circom-language/formats/simplification-json.md index 041dd1ff6..e73c78a4f 100644 --- a/mkdocs/docs/circom-language/formats/simplification-json.md +++ b/mkdocs/docs/circom-language/formats/simplification-json.md @@ -66,7 +66,7 @@ to indicate that we do not want to apply any simplification the generated file ' { } ``` -Finaly, if we run +Finally, if we run ```text circom simplify.circom --r1cs --wasm --simplification_substitution --O1 From 0c572b683f9b4f43c8128140878876cbfbfc4f91 Mon Sep 17 00:00:00 2001 From: shuoer86 <129674997+shuoer86@users.noreply.github.com> Date: Wed, 17 Jan 2024 23:48:59 +0800 Subject: [PATCH 4/5] fix typos --- mkdocs/docs/circom-language/formats/sym.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkdocs/docs/circom-language/formats/sym.md b/mkdocs/docs/circom-language/formats/sym.md index 9407a1572..61fc97332 100644 --- a/mkdocs/docs/circom-language/formats/sym.md +++ b/mkdocs/docs/circom-language/formats/sym.md @@ -69,7 +69,7 @@ to indicate that we do not want to apply any simplification the generated file ' 5,5,0,main.c.in[0] 6,6,0,main.c.in[1] ``` -Finaly, if we run +Finally, if we run ```text circom symbols.circom --r1cs --wasm --sym --O1 From dd51db62994069097f4672665c4f2465c180fe30 Mon Sep 17 00:00:00 2001 From: shuoer86 <129674997+shuoer86@users.noreply.github.com> Date: Wed, 17 Jan 2024 23:49:04 +0800 Subject: [PATCH 5/5] fix typos --- mkdocs/docs/circom-language/tags.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkdocs/docs/circom-language/tags.md b/mkdocs/docs/circom-language/tags.md index 3e172e0a7..1ad4e56af 100644 --- a/mkdocs/docs/circom-language/tags.md +++ b/mkdocs/docs/circom-language/tags.md @@ -33,7 +33,7 @@ The input array `in` is declared with the tag `binary`. This tag means that each Then, whenever the previous template is instantiated, the compiler checks if the array `a` assigned to the input array has the tag binary, since `in` has the tag `binary` in its declaration. If it does not, an error is reported. Notice that the compiler also checks if both arrays have the same size. -It is important to highlight that the compiler does never make any check about the validity of the tags. It is the programmer's responsibility to include the constraints and executable code to guarantee that the inteded meaning of each signal is always true. +It is important to highlight that the compiler does never make any check about the validity of the tags. It is the programmer's responsibility to include the constraints and executable code to guarantee that the intended meaning of each signal is always true. When doing a substitution from a tagged signal to another signal, the tags are always inherited by it (even if it is not declared with it). For instance,