add prover_disabled flag for another go files #27
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds the !prover_disabled build constraint to all platform-specific build configuration files in the prover package, enabling the prover functionality to be disabled at build time via the prover_disabled build tag.
- Adds
&& !prover_disabledto build tags across 6 platform-specific build files - Ensures consistent build constraint patterns across all prover implementations
- Completes the prover disable mechanism alongside existing
rapidsnark.goandrapidsnark_mock.gofiles
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| prover/build_linux_arm64.go | Adds !prover_disabled constraint to Linux ARM64 build configuration |
| prover/build_linux_amd64_noasm.go | Adds !prover_disabled constraint to Linux AMD64 no-asm build configuration |
| prover/build_linux_amd64.go | Adds !prover_disabled constraint to Linux AMD64 build configuration |
| prover/build_dynamic.go | Adds !prover_disabled constraint to dynamic linking build configuration |
| prover/build_darwin_arm64.go | Adds !prover_disabled constraint to Darwin ARM64 build configuration |
| prover/build_darwin_amd64.go | Adds !prover_disabled constraint to Darwin AMD64 build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vmidyllic
approved these changes
Nov 13, 2025
olomix
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.