Skip to content

Conversation

@anjos
Copy link
Member

@anjos anjos commented Oct 14, 2025

There is a regression on click 8.3.x that disallows the use of "secondary" flag options in the style -a/-A for set/unset flag. I'm not sure why the problem appears yet, but there is a new test in this branch that shows it.


📚 Documentation preview 📚: https://clapper--22.org.readthedocs.build/en/22/

@anjos
Copy link
Member Author

anjos commented Oct 14, 2025

Some other tests are not passing either on this branch... Not sure why. Changes are limited to the bump click 8.1.x -> 8.3.0

@anjos anjos changed the title Add test to show click regression on boolean flags Support clicks UNSET condition for is_flag and default Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/clapper
  click.py 42-44, 363-365, 382
Project Total  

This report was generated by python-coverage-comment-action

@anjos
Copy link
Member Author

anjos commented Oct 15, 2025

@Yannick-Dayer: I managed to fix this package without requiring a new version of auto-intersphinx for now. I need this one a bit more urgently than auto-intersphinx. If you can tag and release this first, it would help us!

@anjos
Copy link
Member Author

anjos commented Oct 15, 2025

@Yannick-Dayer: please wait - there is now a regression with click <8.3...

@anjos
Copy link
Member Author

anjos commented Oct 15, 2025

@Yannick-Dayer: this is now also fixed - ready to be merged.

Copy link
Member

@Yannick-Dayer Yannick-Dayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just find weird to include the "dev" dependencies in the default environments.

@Yannick-Dayer Yannick-Dayer merged commit 2011c40 into main Oct 16, 2025
10 checks passed
@Yannick-Dayer Yannick-Dayer deleted the click-regression-secondary-flag branch October 16, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants