-
Notifications
You must be signed in to change notification settings - Fork 0
Support clicks UNSET condition for is_flag and default #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some other tests are not passing either on this branch... Not sure why. Changes are limited to the bump click 8.1.x -> 8.3.0 |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
@Yannick-Dayer: I managed to fix this package without requiring a new version of auto-intersphinx for now. I need this one a bit more urgently than auto-intersphinx. If you can tag and release this first, it would help us! |
|
@Yannick-Dayer: please wait - there is now a regression with click <8.3... |
|
@Yannick-Dayer: this is now also fixed - ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just find weird to include the "dev" dependencies in the default environments.
There is a regression on click 8.3.x that disallows the use of "secondary" flag options in the style
-a/-Afor set/unset flag. I'm not sure why the problem appears yet, but there is a new test in this branch that shows it.📚 Documentation preview 📚: https://clapper--22.org.readthedocs.build/en/22/