fix: managing slurms without accounting and a few bugs #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Slurm installations have accounting disabled and you can only get information about the job using scontrol show job <slurm-job-id> For now, we just handle the failed call here.
It can happen that the logs folder is empty (all jobs are pending) but the database is not empty. We should not delete the logs folder in this case.
when installing with pixi global install, the CONDA_PREFIX and PATH env variables are shadowed (see prefix-dev/pixi#1382) and this breaks binary discovery (e.g. python) when a job is submitted.
This can happen on slurm installations where accounting is disabled.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Yannick-Dayer
approved these changes
Jul 18, 2024
Member
Yannick-Dayer
left a comment
Yannick-Dayer
left a comment
There was a problem hiding this comment.
Looks good. 👍🏼
I don't have the setup to try that specific case but the logic seems OK, using scontrol instead of sacct and adapting the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: handle sacct failures
fix: retrieve job status from scontrol when sacct is not available
fix: do not delete the logs folder when the database is not empty
fix: do not recommend installing with pixi
📚 Documentation preview 📚: https://gridtk--6.org.readthedocs.build/en/6/