Add state filter tests and handle readonly database #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding some tests to make sure state-based filtering of jobs works
It can happen that the database could be read-only but running commands like gridtk list should still work.
Handle cases when job_manager.logs_dir is not relative to logs. Also output valid states when state callback fails.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
Member
Yannick-Dayer
left a comment
Yannick-Dayer
left a comment
There was a problem hiding this comment.
Looks good.
Can you just confirm the output path comment (that it is doing what is expected).
Yannick-Dayer
changed the title
Yannick-Dayer
previously approved these changes
Jul 23, 2024
Member
Yannick-Dayer
left a comment
Yannick-Dayer
left a comment
There was a problem hiding this comment.
Seems much more logical to me like this.
Add an indication on how to specify ranges in the help message of the `--jobs` (`-j`) option of the `gridtk list` command.
Yannick-Dayer
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: more error handling
fix: when the database is read-only
test: add tests for state-based filtering
📚 Documentation preview 📚: https://gridtk--8.org.readthedocs.build/en/8/