Fixed jQuery.each loop #439

Merged
merged 2 commits into from Aug 28, 2016

Projects

None yet

4 participants

@tschallacka

the code referenced this, but that defeats the purose of using each. prevents double wrapping of elements, and animations to continue when they should stop.

mdibbets added some commits Aug 26, 2016
@mdibbets mdibbets Fixed jQuery.each loop, the code referenced this, but that defeats th…
…e object of using each. prevents double wrapping of elements, and animations to continue when they should stop.
66c06df
@mdibbets mdibbets Forgot to add the type check to see if it was already added bf0d5a6
@idiot idiot merged commit f36e9d8 into idiot:master Aug 28, 2016
@damien-dd
damien-dd commented on bf0d5a6 Sep 20, 2016 edited

This breaks the following feature described in the doc.:

If a slide gets added or removed, you should call this otherwise things'll probably break.

var slider = $('.my-slider').unslider();

// I don't like this last slide, let's get rid of it
slider.find('li:last').remove();

// Let's recalculate Unslider so it knows what's going on
slider.unslider('calculateSlides');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment