New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples can be run on Ubuntu 14.04 LTS 64-bit #30

Merged
merged 8 commits into from Oct 2, 2014

Conversation

Projects
None yet
2 participants
@ButchDean
Contributor

ButchDean commented Sep 27, 2014

When using the default make file I was unable to build the example for Ubuntu, there were unresolved references and other issues. I separated out that I know works under Ubuntu and made the appropriate source code changes to link correctly to the OpenGL libs and source includes.

The original makefile should still be useful for Mac.

@ButchDean ButchDean changed the title from Example can be run on Ubuntu 14.04 LTS 64-bit to Examples can be run on Ubuntu 14.04 LTS 64-bit Sep 27, 2014

@idmillington

This comment has been minimized.

Show comment
Hide comment
@idmillington

idmillington Oct 1, 2014

Owner

It would be better to tell the compiler that the include directory is in its set of include paths, rather than all the conditional includes with relative file paths. That makes the files unduly complex, I think.

Owner

idmillington commented Oct 1, 2014

It would be better to tell the compiler that the include directory is in its set of include paths, rather than all the conditional includes with relative file paths. That makes the files unduly complex, I think.

@ButchDean

This comment has been minimized.

Show comment
Hide comment
@ButchDean

ButchDean Oct 1, 2014

Contributor

Sure, I'll look into correcting that.

Contributor

ButchDean commented Oct 1, 2014

Sure, I'll look into correcting that.

@ButchDean

This comment has been minimized.

Show comment
Hide comment
@ButchDean

ButchDean Oct 2, 2014

Contributor

All updated and generally improved as per your requirements.

Contributor

ButchDean commented Oct 2, 2014

All updated and generally improved as per your requirements.

@idmillington

This comment has been minimized.

Show comment
Hide comment
@idmillington

idmillington Oct 2, 2014

Owner

Thank you so much for sticking with this and making these changes. I'm merging now.

Owner

idmillington commented Oct 2, 2014

Thank you so much for sticking with this and making these changes. I'm merging now.

@idmillington idmillington reopened this Oct 2, 2014

idmillington added a commit that referenced this pull request Oct 2, 2014

Merge pull request #30 from ButchDean/master
Examples can be run on Ubuntu 14.04 LTS 64-bit

@idmillington idmillington merged commit fd0cf49 into idmillington:master Oct 2, 2014

@ButchDean

This comment has been minimized.

Show comment
Hide comment
@ButchDean

ButchDean Oct 2, 2014

Contributor

No problem at all. Thank you for the great book and the merge!

Contributor

ButchDean commented Oct 2, 2014

No problem at all. Thank you for the great book and the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment