New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order comments by mf2 dt-published or dt-updated #1104

Closed
snarfed opened this Issue Nov 27, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@snarfed

snarfed commented Nov 27, 2015

...if available. looks like right now they're ordered by webmention receipt time.

requested here by @beck24. the use case is bridgy (etc), since it polls and so it often sends multiple comments in batches.

example: these two comments on http://known.mattbeckett.me/2015/buy-nothing-this-black-friday :

happy thanksgiving btw!

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

kylewm added a commit to kylewm/Known that referenced this issue Feb 9, 2016

bugfix: read dt-published from incoming webmentions correctly
previously array_shift(array_pop(...)); was probably failing but
hidden by the insidious @ operator

Fixes idno#1104
@snarfed

This comment has been minimized.

Show comment
Hide comment
@snarfed

snarfed Feb 10, 2016

🎉 🙏

snarfed commented Feb 10, 2016

🎉 🙏

@jaduncan

This comment has been minimized.

Show comment
Hide comment
@jaduncan

jaduncan Mar 26, 2017

I'm currently getting incorrectly ordered comments on FB and Twitter comments sent from bridgy. I'm running 0.9.2 as provided by Reclaim Hosting (stock, I would think) and the order is broken in that, while comments from different bridgy pushes are ordered correctly, if bridgy is picking up multiple comments in one check (let's say that 10 have been added since bridgy last scanned FB) then the order within those 10 comments is random.

jaduncan commented Mar 26, 2017

I'm currently getting incorrectly ordered comments on FB and Twitter comments sent from bridgy. I'm running 0.9.2 as provided by Reclaim Hosting (stock, I would think) and the order is broken in that, while comments from different bridgy pushes are ordered correctly, if bridgy is picking up multiple comments in one check (let's say that 10 have been added since bridgy last scanned FB) then the order within those 10 comments is random.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment