New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incoming webmentions: use u-url property instead of source URL #160

Closed
snarfed opened this Issue Jan 6, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@snarfed

snarfed commented Jan 6, 2014

low priority:

right now, it looks like idno's webmention handler uses the source query parameter as the source's canonical URL. no surprise there: most current webmention implementations do this, since they're almost always the same. http://brid.gy/ is one case where they're different, though, and in that case the u-url property should take precedence (i hope).

e.g. bridgy generated the likes and retweets on http://werd.io/2014/why-i-love-silicon-valley-despite-hating-silicon-valley#comments, and the permalinks all point to brid.gy, but they should ideally point to the twitter.com links in the u-urls instead.

@ghost ghost assigned benwerd Jan 6, 2014

@benwerd

This comment has been minimized.

Show comment
Hide comment
@benwerd

benwerd Jan 6, 2014

Member

Was just wondering about this. Thanks! Will take a look.

Member

benwerd commented Jan 6, 2014

Was just wondering about this. Thanks! Will take a look.

@ruihildt

This comment has been minimized.

Show comment
Hide comment
@ruihildt

ruihildt Aug 14, 2015

@benwerd , does this mean this bug is gonna stay closed forever ?

ruihildt commented Aug 14, 2015

@benwerd , does this mean this bug is gonna stay closed forever ?

@benwerd

This comment has been minimized.

Show comment
Hide comment
@benwerd

benwerd Aug 14, 2015

Member

This bug is closed because it was fixed with a commit. There is another bug, #603, that needs to be addressed.

Member

benwerd commented Aug 14, 2015

This bug is closed because it was fixed with a commit. There is another bug, #603, that needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment