Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Possible conflict with Core Like and KnownReactions Plugin #1753
While trying to do this:
Update to Known v0.9.9
I encountered this error:
Likes and reposts previously displayed properly on my site using the KnownReactions plugin are broken and/or don't display at all/properly.
Some other notes:
This is a previously seen issue going back almost a year with relation to the KnownReactions plugin and there's also a thread describing the same problem(s) here: kylewm/KnownReactions#17
I thought I'd also post this in the issue queue here to get some additional eyeballs on it, particularly as it appears that there's potentially some relation to changes in the core "Like" (aka Bookmark) plugin since 0.9.2 which have occurred since the issue began.
Ideally, unless there are licensing or other issues (ie does @kylewm mind?), I would have expected that given the ubiquity of like/repost functionality, that all of KnownReactions might have all been rolled up into core in v0.9.9 or might be for v1.0.
From what I can tell, people, like me, who were using the released version of 0.9.2 didn't have any problems, but those using the master branch since then have. At some point it appears there was some code added to the "Like" core plugin that also allowed "likes" and "reposts" into the arrays along with "bookmarks" (for use in an more integrated UI using the bookmarklet to allow switching between
I also have feeling that some of the renaming within core when the core "Like" plugin functionally
Give us some context, it'd also be really handy if you could tell us the contents of your
Possibly related to this:
I turned debugging up to 4 while working on a new plugin. Saw many many errors in the PHP logs afterwards, all of the form:
Offending line is:
<h2 class="idno-bookmark"><?=$icon?><a href="<?= $vars['object']->body; ?>" class="<?= $class ?> p-name" target="_blank"><?= $this->parseURLs(htmlentities(strip_tags($body)), $rel) ?></a> </h2>