[Micropub] Photo posts not containing proper photo link anymore, but inlined HTML image instead

[raucao]

While trying to do this:

Post a photo via Micropub. I post my Instagram photos to https://updates.kip.pe/ from IFTT, with a form payload like this:

h=entry&content={{Caption}}&photo={{SourceUrl}}&syndication={{Url}}&access_token=b71dfd944abbc8955fe84fc2e0229889

I encountered this error:

Before recently (I couldn't pinpoint the change that broke it), my posts would be stored as normal photo posts. I could edit them, change the picture, sync them to other sites, etc.. But after some update, they are now inlined as HTML content. And now, editing doesn't work anymore, i.e. I cannot change the photo, even if I remove the inlined one, save, and then try again. Also, my integration to sync it to Mastodon broke, because it can't deal with the inline photo. Here's how it looks in my edit UI now:

Some other notes:

version = "0.9.9-a"
build = 2018082301

• Using MySQL
• Diagnostics page says "You are running PHP version 5.5.9-1ubuntu4.25, which cannot run Known." but everything else has been working fine. However, the editing bug might have to with a missing PHP feature? Not sure what that could be.
• The editing issues could also be related to #2008

[mapkyca]

I think the only recent changes to the photo endpoint was to handle multiple images.

Once I get through my backlog of emails I'll see if I can work out the breaking change...

[benwerd]

I'm trying to take a look also. I think it's a bigger issue than just micropub, at first glance - it looks like images never link to their full source anymore.

[mapkyca]

In micropub I noticed there's a fetch by url and a post image $_FILE which are two possible routes. IIRC the former does a fetch and save (iirc), but it might be that we simplified this by using a proxied image... I'll take a look

[raucao]

Anyone had a chance to look into this yet?

[mapkyca]

Just had a couple of minutes to look at it, PR waiting.

[raucao]

Hooray, it works! Thank you!