New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page metadata turns user icon into preview image #2230

Open
benwerd opened this Issue Oct 12, 2018 · 13 comments

Comments

3 participants
@benwerd
Member

benwerd commented Oct 12, 2018

A user's photo should never be the preview image of a content page. (It could reasonably be the preview image of a profile page.) The preview image function needs to be able to prevent this from happening.

@mapkyca

This comment has been minimized.

Collaborator

mapkyca commented Oct 12, 2018

Example?

@mapkyca

This comment has been minimized.

Collaborator

mapkyca commented Oct 13, 2018

This ticket needs a bit more information:

Are we talking about the feed page, or a specific entity type (e.g. blog)? Is it related to open graph and/or the new structured data format? Or both?

I'm assuming you're talking about longform posts which attempt to extract a preview from images within the text, and I suspect (although I've not looked at the code) will fall back to owner if not found.

Is this what you're talking about here?

@jgmac1106

This comment has been minimized.

jgmac1106 commented Oct 14, 2018

Here is an example as it usually shows during syndication but also in readers:

https://quickthoughts.jgregorymcverry.com/2018/10/14/scott_gruber-not-using-word-self-dogfooding-anymore-personal

https://twitter.com/jgmac1106/status/1051600113771171842

I am way to ugly for people to look at,

I tried status updates, reply posts, and articles.

All post types without an image show my avatar image.

Articles with an image uploaded will take first image
Articles where I manually add an image and add u-photo property class="u-photo" show broken image
Articles where I manually add an image and ad u-featured work fine
If I upload an image and then click on source editor to add additional properties just does funky stuff, but that isn't for this issue.

@jgmac1106

This comment has been minimized.

jgmac1106 commented Oct 14, 2018

This seems to be throwing the image: link rel="apple-touch-icon" and the OpenGraph: <meta property="og:image" content="https://quickthoughts.jgregorymcverry.com/file/6802fbcdd3fada8cb61ffb798978f72f/thumb.jpg" />

Is there anyway I can strip the OG stuff and just use the u-featured property?

@jgmac1106

This comment has been minimized.

jgmac1106 commented Oct 15, 2018

Turning off the setting for "Avatar as icon" removes the image from OpenGraph.

@mapkyca

This comment has been minimized.

Collaborator

mapkyca commented Oct 15, 2018

I'd argue that if this only shows when "Avatar as icon" is set, then this isn't a bug and things are behaving as expected...

@jgmac1106

This comment has been minimized.

jgmac1106 commented Oct 15, 2018

@mapkyca

This comment has been minimized.

Collaborator

mapkyca commented Oct 15, 2018

Yeah, the open graph plugin was something I wrote a while ago but the code was essentially merged into core and so that plugin is deprecated.

@jgmac1106

This comment has been minimized.

jgmac1106 commented Oct 15, 2018

Never mind, still getting the opengraph image even when the box is checked off. Here is an example: https://twitter.com/jgmac1106/status/1051900091857063937

If the goal is to strip away syndication by default maybe Open Graph should be a plug in so I can turn it off. I don’t have a facebook account so I don’t really care about it.

(Originally published at: http://jgregorymcverry.com/7917-2/)

@jgmac1106

This comment has been minimized.

jgmac1106 commented Oct 15, 2018

I looked at the source code of this post: http://quickthoughts.jgregorymcverry.com/2018/10/15/i-also-think-these-features-will-be and the OpenGraph stuff is gone but the images for retina apple display still seem to be there.

(Originally published at: http://jgregorymcverry.com/7919-2/)

@mapkyca

This comment has been minimized.

Collaborator

mapkyca commented Oct 17, 2018

Retina icons shouldn't be profile pics however, they're mainly for if you bookmark the page on your iThing so you get a Known icon rather than the default.

@jgmac1106

This comment has been minimized.

jgmac1106 commented Oct 17, 2018

@mapkyca

This comment has been minimized.

Collaborator

mapkyca commented Oct 17, 2018

Yes, OG tags should always be present, that's normal.

However, on my site, when I disable "avatar as icon", the og:image flips from the profile icon to the default K icon.

@benwerd benwerd added this to To do in Known 1.0 Oct 25, 2018

@benwerd benwerd moved this from To do to High priority in Known 1.0 Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment